Skip to content

Conversation

minghangli-uni
Copy link
Collaborator

@minghangli-uni minghangli-uni marked this pull request as ready for review August 1, 2025 00:25
@minghangli-uni
Copy link
Collaborator Author

minghangli-uni commented Aug 4, 2025

It would be good if you could have a look too? @dougiesquire

@anton-seaice
Copy link
Contributor

This looks good @minghangli-uni - do you have example output ?

We'll need to note this weird inter-dependency on setting minimum depth consistently with MOM_input somewhere (the config docs I think ?) - can you make an issue / PR for that

@minghangli-uni
Copy link
Collaborator Author

This looks good @minghangli-uni - do you have example output ?

Ah yeah, i just regenerated those two and did a comparison. They are identical for both w/ mask and w/o mask.

/g/data/tm70/ml0072/COMMON/git_repos/workflow_grid_mesh_generation/2025.08.08.3.25km

We'll need to note this weird inter-dependency on setting minimum depth consistently with MOM_input somewhere (the config docs I think ?) - can you make an issue / PR for that

I'll do that .

Copy link
Contributor

@anton-seaice anton-seaice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @minghangli-uni

Please squash merge!

@minghangli-uni minghangli-uni merged commit 71fcda2 into main Aug 8, 2025
4 checks passed
@minghangli-uni minghangli-uni deleted the 311-ocean-mask-input-files branch August 8, 2025 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ocean mask input files

2 participants