Davide/remove hres eccb #59
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added integration tests for hres_ic Added development environment
Before the actual test run, there is a setup step that sets up the work directory and data paths Currently the tests are not meant to be run in parallel yet, as the setup should be re-structured to be run only once (before the test run) and not for each parallel worker.
- Mock the shutil.move function so the outputs can be sent to a custom path and there is no need for copying the input data - Use fixtures - Use mark.parameterize - Use built-in tmp_path_factory fixture - Enable parallelized tests Tests can now be run with 'pytest -n <num> | auto' to run in parallel.
…e' to make it general. Also changed the entry points to only include replace_landsurface (old 'hres_ic').
…ce_landsurface' function
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This PR head branch was based off
davide/integration_tests_pytestto provide a way to test the scripts after their modification.This branch should be rebased to
mainafter #58 is merged, before marking it as "ready to be reviewed".Overview
Fixes #31.
This PR removes the
hres_eccb.pyscript and entry point, and renames thehres_ic.pyscript to the more generalreplace_landsurface.py.The entry point
hres_icwas also renamed toreplace_landsurfaceto match the name of the package (which is usually recommended).Testing
The integration tests pass with minor modifications (mainly renaming of functions). Obviously, no input/output data were changed.
The old
test_hres_eccbtest is now included within thetest_replace_landsurfacefunction with thereplace_landsurface_era5land_2ID, as it tests theera5landtype (same as test n. 1) with different input data.Why is this important
This simplifies the codebase and removes redundancies.
Important
SUITE MODIFICATIONS NEEDED
These changes break back-compatibility with the current revision of the RNS suite.
An updated version of the suite is available in this branch.