Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACCESS-ESM1.5 & ACCESS-ESM1.6: remove versions from dependencies #210

Merged
merged 1 commit into from
Mar 11, 2025
Merged

ACCESS-ESM1.5 & ACCESS-ESM1.6: remove versions from dependencies #210

merged 1 commit into from
Mar 11, 2025

Conversation

harshula
Copy link
Collaborator

  • The versions do not need to be hardcoded in the SPRs because we define the required versions
    in the spack.yaml Spack environment file.
  • Removing hdf5 because it is a dependency of netcdf-c, not oasis3-mct.

@harshula harshula self-assigned this Mar 10, 2025
@harshula
Copy link
Collaborator Author

Testing

ACCESS-NRI/ACCESS-ESM1.5#28 (comment)

@harshula harshula requested a review from penguian March 11, 2025 00:29
blimlim
blimlim approved these changes Mar 11, 2025
View reviewed changes
Copy link

@blimlim blimlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @harshula. I'm not on top of the details, however the results from running all look good

penguian
penguian approved these changes Mar 11, 2025
View reviewed changes
Copy link
Contributor

@penguian penguian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes all look reasonable.

@harshula harshula merged commit 021bc52 into main Mar 11, 2025
1 check failed
This was referenced Mar 11, 2025
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penguian penguian penguian approved these changes

@blimlim blimlim blimlim approved these changes

@aidanheerdegen aidanheerdegen Awaiting requested review from aidanheerdegen

@dougiesquire dougiesquire Awaiting requested review from dougiesquire

Assignees

@harshula harshula

Labels
None yet
Projects
ACCESS-ESM1.5 Spack
Status: Done
ACCESS-ESM1.6
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harshula @penguian @blimlim