Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: make sphinx build of docs work #32

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

PinkShnack
Copy link
Contributor

See #31

@PinkShnack
Copy link
Contributor Author

It builds locally, except for the unicode character mu as described here: #31 (comment)

@PinkShnack
Copy link
Contributor Author

@paulmueller why was the sphinx version limited to 4.3 before, do you remember?

@paulmueller
Copy link
Member

paulmueller commented Jan 11, 2025

@PinkShnack This was because of incompatibilities with sphinx, bibtex, and the rtd theme. The version pins can be removed now.

@PinkShnack
Copy link
Contributor Author

If you think this is okay, and you can check on readthedocs that the docs are building correctly, then this PR should be done.

@paulmueller
Copy link
Member

Hi @PinkShnack, I would say that the unicode character problem is a requirement for fixing issue #31, since it is mentioned there. Alternatively, you could create a new issue for the unicode character problem and I would then merge this here so we can close #31.

@paulmueller paulmueller merged commit e496a84 into AFM-analysis:master Jan 14, 2025
0 of 9 checks passed
@PinkShnack
Copy link
Contributor Author

Updated the language to 'en'. You can merge, and close #31

@PinkShnack PinkShnack deleted the 31_fix_docs_build branch January 14, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants