Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the simple_convection problem #3016

Merged
merged 13 commits into from
Jan 28, 2025
Merged

add the simple_convection problem #3016

merged 13 commits into from
Jan 28, 2025

Conversation

zingale
Copy link
Member

@zingale zingale commented Jan 7, 2025

this mirrors the convection problem in pyro

PR summary

PR motivation

PR checklist

  • test suite needs to be run on this PR
  • this PR will change answers in the test suite to more than roundoff level
  • all newly-added functions have docstrings as per the coding conventions
  • the CHANGES file has been updated, if appropriate
  • if appropriate, this change is described in the docs

@zingale zingale changed the title [WIP] add the simple_convection problem add the simple_convection problem Jan 8, 2025
@zingale
Copy link
Member Author

zingale commented Jan 8, 2025

this largely agrees with pyro now

@zingale zingale merged commit 9fdc8cb into AMReX-Astro:development Jan 28, 2025
25 checks passed
@zingale zingale deleted the add_convection_problem branch January 28, 2025 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximumcats maximumcats maximumcats approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zingale @maximumcats