Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement iMultiFab #410

Merged
merged 7 commits into from
Jan 29, 2025
Merged

Implement iMultiFab #410

merged 7 commits into from
Jan 29, 2025

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jan 29, 2025

Generalize the MultiFab logic and reuse as much as possible for the iMultiFab bindings.


# assign 3: loop through boxes and launch kernels
for mfi in imfab_device:
bx = mfi.tilebox().grow(ngv) # noqa

Check notice

Code scanning / CodeQL

Unused local variable Note test

Variable bx is not used.
# assign 3
with cupyx.profiler.time_range("assign 3 [()]", color_id=0):
for mfi in imfab_device:
bx = mfi.tilebox().grow(ngv) # noqa

Check warning

Code scanning / CodeQL

Variable defined multiple times Warning test

This assignment to 'bx' is unnecessary as it is
redefined
before this value is used.
This assignment to 'bx' is unnecessary as it is
redefined
before this value is used.
return mm

for mfi in imfab_device:
bx = mfi.tilebox().grow(ngv) # noqa

Check warning

Code scanning / CodeQL

Variable defined multiple times Warning test

This assignment to 'bx' is unnecessary as it is
redefined
before this value is used.
x[...] = 7

for mfi in imfab_device:
bx = mfi.tilebox().grow(ngv) # noqa

Check notice

Code scanning / CodeQL

Unused local variable Note test

Variable bx is not used.
namespace
{
template<typename T>
void make_FabArray_T(py::module &m, std::string const &name)

Check notice

Code scanning / CodeQL

Unused static function Note

Static function make_FabArray_T is unreachable
@ax3l ax3l merged commit f6d7201 into AMReX-Codes:development Jan 29, 2025
17 checks passed
@ax3l ax3l deleted the topic-imultifab branch January 29, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant