Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6주자 세미나 과제 #7

Closed
wants to merge 70 commits into from
Closed

6주자 세미나 과제 #7

wants to merge 70 commits into from

Conversation

Ohjackson
Copy link
Collaborator

🚀 PR 요약 #6

🛠 수행 작업

🍎 차트뷰를 만들어 보았습니다!

<간단 설명>

  • ScrollView 안에 row를 넣어서 누르면 row안에 정의된 조건에 따라 네비게이션 되게 하였습니다.
    list 를 사용하면 뷰 레이아웃에 대한 제약이 많아 scrollview를 사용했습니다!

🍎 커스텀 Tabbar를 만들어 보았습니다!

<사용 코드>

  • .toolbar(.hidden, for: .tabBar) 사용후var tabBar: some View {안에 스타일을 넣었습니다

영상

2024-11-29.20.54.27.mov

🎯 첨언

감사합니다!!!

🐔 참고 블로그

https://velog.io/@soc06212/SwiftUI-TabView-TabBar-커스터마이징

@Ohjackson Ohjackson self-assigned this Nov 29, 2024
Copy link
Member

@sozohoy sozohoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. PR 단위가 너무 큽니다. 이전에 과제했던 것도 같이 올라온 것 같은데 이유를 알아보셔야 할 것 같아요
  2. 네이밍과 코드를 작성하는 것에 조금 더 디테일하게 진행해야할 것 같습니다. 간격이 라인별로 다 다르고 네이밍도 a,b,c로 하면 안될 것 같아요

고생하셨습니다!

return button
}()

let keychain = KeychainSwift()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • KeychainSwift 라이브러리를 왜 쓰고 계신가요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

서버에서 받은 토큰 관리를 위해 사용했던 것 같아요!

Comment on lines +17 to +33
NavigationStack {

ScrollView {



ForEach(appList, id: \.ranking) { app in
AppRow(app: app)

}
.padding(.horizontal, 13)


}
.background(Color.black.ignoresSafeArea())

}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 간격 통일성이 필요해보입니다 !!

Comment on lines +66 to +79
Button(action: {
showDetailView.toggle()
}) {
Text(app.downloadState.rawValue)
.font(.body)
.padding(.vertical, 6)
.padding(.horizontal, 12)
.foregroundColor(.blue)
.background(Color.white.cornerRadius(10))
}
}
.onTapGesture {
showDetailView.toggle()
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 버튼과 화면에 동일한 액션을 진행하는 것 같은데 이유가 뭘까요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

처음에는 버튼 터치와, 화면의 터치의 액션 나누려다가 버튼 액션에 뭘 넣을지 마땅히 생각이 안 나서 일단 같은 액션으로 했습니다!


@State private var selected: Tab = .a

var body: some View {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 탭뷰 사용 방식을 수정해야될 것 같아요!
  • 네이밍을 신경쓰세요!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다 ㅠ

@Ohjackson Ohjackson closed this Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants