Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Issues in script.sh (Cloning, Dependency Installation, Flask Execution & S2V Extraction Path) #188

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SnehaChaursia
Copy link

Description

This PR addresses the issue #186 by fixing script.sh to automate the setup process as described in the README.md.

Changes:

  • Cloning Issue: The script no longer clones the repository if it already exists locally.
  • Dependency Installation: Added pip install -r requirements.txt to install dependencies automatically.
  • S2V Model Extraction Path: Corrected the extraction path for the Sense2Vec model to backend/Gs2v_old.
  • Flask Server Execution: The Flask server now starts automatically using python backend/server.py.
  • README.md Update: Updated the README to reflect the correct script execution steps.

Expected Behavior (according to README)

  • The script should install dependencies.
  • The model should be extracted in the correct directory.
  • The Flask server should be started.

Actual Behavior before Fix

  • The repository is cloned again, even if it already exists.
  • Dependencies are not installed.
  • The Flask server does not start.
  • The model is extracted incorrectly, causing errors in server.py.

Expected Outcome after Fix

  • Skip cloning if the repository already exists.
  • Install dependencies automatically.
  • Correctly extract the S2V model into the proper directory.
  • Start the Flask server automatically.

Additional Context

These fixes ensure that script.sh runs smoothly as described in the README, making it easier for users to set up the project without manual intervention.

@Aditya062003 Looking forward to your review and feedback!

@SnehaChaursia SnehaChaursia marked this pull request as draft February 5, 2025 15:33
@SnehaChaursia SnehaChaursia marked this pull request as ready for review February 5, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant