Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Import Error: ajv-draft-04 #268

Merged
merged 1 commit into from
Feb 11, 2025
Merged

Conversation

bh2smith
Copy link
Contributor

@bh2smith bh2smith commented Feb 6, 2025

Users of this package keep running into the following import issue: This forces users to include ajv-draft-04 into their project dependencies even if they are not directly using it. This PR proposes moving the import statement into the only code block where it is actually required and thus (hopefully) avoiding the error. Its a bit surprising that the dependencies don't force the package to be there. Maybe there is some other problem at play...

node:internal/modules/cjs/loader:1248
  const err = new Error(message);
              ^

Error: Cannot find module 'ajv/dist/core'
Require stack:
- home/project/node_modules/ajv-draft-04/dist/index.js
- home/project/node_modules/@apidevtools/swagger-parser/lib/validators/schema.js
- home/project/node_modules/@apidevtools/swagger-parser/lib/index.js
    at Module._resolveFilename (node:internal/modules/cjs/loader:1248:15)
    at Module._load (node:internal/modules/cjs/loader:1074:27)
    at TracingChannel.traceSync (node:diagnostics_channel:315:14)
    at wrapModuleLoad (node:internal/modules/cjs/loader:217:24)
    at Module.require (node:internal/modules/cjs/loader:1339:12)
    at require (node:internal/modules/helpers:135:16)
    at Object.<anonymous> (home/project/node_modules/ajv-draft-04/dist/index.js:4:16)
    at Module._compile (node:internal/modules/cjs/loader:1546:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1691:10)
    at Module.load (node:internal/modules/cjs/loader:1317:32) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [
    'home/project/node_modules/ajv-draft-04/dist/index.js',
    'home/project/node_modules/@apidevtools/swagger-parser/lib/validators/schema.js',
    'home/project/node_modules/@apidevtools/swagger-parser/lib/index.js'
  ]
}

bh2smith added a commit to BitteProtocol/make-agent that referenced this pull request Feb 6, 2025
There seems to be some unusual import error that end users get without
this package. I have proposed a potential solution in the dependency
repo: APIDevTools/swagger-parser#268

In the meantime, we just put this back here.
@philsturgeon philsturgeon enabled auto-merge (squash) February 11, 2025 13:55
@philsturgeon philsturgeon merged commit ff79822 into APIDevTools:main Feb 11, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants