Fixed the faker.js repo link in the README#181
Open
gynekolog wants to merge 1 commit intoAPIs-guru:mainfrom
Open
Fixed the faker.js repo link in the README#181gynekolog wants to merge 1 commit intoAPIs-guru:mainfrom
gynekolog wants to merge 1 commit intoAPIs-guru:mainfrom
Conversation
|
changing the link in README does not change the fact that the code still uses the old faker library which does not exist anymore to result in a freeze during the installation. I tried to replace it in the package.json and faker.ts files but then the build steps gave more problems with node version 18 meaning we need more fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.