Skip to content

[#1] - Feature/generate circles function #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 4, 2020

Conversation

Conradox
Copy link
Contributor

@Conradox Conradox commented Sep 1, 2020

Required sub-tasks for this task:

  • Add generate_circles function.
  • Add docstring.
  • Add information in the readme.
  • Add tests.

@Conradox Conradox linked an issue Sep 1, 2020 that may be closed by this pull request
20 tasks
@Conradox Conradox added the enhancement New feature or request label Sep 1, 2020
@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #12 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           27        30    +3     
=========================================
+ Hits            27        30    +3     
Impacted Files Coverage Δ
src/sklearn.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa9696d...2136e1e. Read the comment docs.

@Conradox Conradox force-pushed the feature/generate_circles_function branch from 4a7ec47 to 6d3cfef Compare September 1, 2020 22:31
@filipebraida
Copy link
Contributor

@Conradox não tá faltando os testes?

@Conradox
Copy link
Contributor Author

Conradox commented Sep 3, 2020

Tinha esquecido de dar o push.

@filipebraida filipebraida merged commit b948371 into master Sep 4, 2020
@filipebraida filipebraida deleted the feature/generate_circles_function branch September 4, 2020 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Interface para os geradores do sklearn
2 participants