Skip to content

Feature/Generate_Low_Rank_Matrix_2 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 5, 2020
Merged

Feature/Generate_Low_Rank_Matrix_2 #18

merged 6 commits into from
Sep 5, 2020

Conversation

yaansz
Copy link
Member

@yaansz yaansz commented Sep 5, 2020

v2

@yaansz yaansz requested review from Conradox and filipebraida and removed request for Conradox September 5, 2020 00:18
@yaansz yaansz linked an issue Sep 5, 2020 that may be closed by this pull request
Interface para os geradores do sklearn #1
Open
20 tasks
@codecov
Copy link

codecov bot commented Sep 5, 2020 •
edited
Loading

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #18   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           33        36    +3     
=========================================
+ Hits            33        36    +3
Impacted Files Coverage Δ
src/sklearn.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34ff75b...22ae2c6. Read the comment docs.

filipebraida
filipebraida requested changes Sep 5, 2020
View reviewed changes
src/sklearn.jl Outdated
tail_strength = tail_strength,
random_state = random_state)
#return convert(features, labels)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Por que tá comentado?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

na verdade, esqueci de alterar ali na linha 265, mas o retorno da função low_level_matrix é único.

Returns:
X: array of shape [n_samples, n_features] (The matrix).

Então pelo que entendi não precisa aplicar o convert né? (ele também da um erro, se eu aplico)

MethodError: no method matching convert(::Float64, ::Float64)

Copy link
Member Author

@yaansz yaansz Sep 5, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fiz a alteração lá, dei uma lida melhor pra entender. Mas n sei se está certo :(

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nesse caso não. Ele não é um problema de classificação. Acho melhor retornar a matriz mesmo.

@filipebraida filipebraida merged commit f181872 into master Sep 5, 2020
@filipebraida filipebraida deleted the feature/generate_low_rank_matrix_2 branch September 5, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipebraida filipebraida filipebraida requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interface para os geradores do sklearn
2 participants
@yaansz @filipebraida