Fix dependabot npm version by updating lockfileVersion in package-lock.json #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace lockfileVersion 1 (npm v6) with lockfileVersion 3 to become compliant with npm 7 and higher. The update was performed using the following command: npm update --package-lock-only --legacy-peer-deps Allowing --legacy-peer-deps due to the foreman-ignored dependency 'react-redux-test-utils'.
This reverts commit 984f699. The commit was an educated guess to force a higher npm version than 6 for dependabot. However, dependabot decides which npm version to use based on the lockfileVersion in package-lock.json. Compare: https://github.com/dependabot/dependabot-core/blob/80315238145998ddfea4d3bfc0a5525973f231d5/npm_and_yarn/lib/dependabot/npm_and_yarn/helpers.rb#L47
|
Printing the beginning of the diff here because github doesn't show: |
dosas
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even when explicitly stating the npm/node version in package.json, dependabot uses npm v6 still.
It seems like dependabot relies on the package-lock.json's lockfileVersion to decide on its npm version (compare here). Therefore, updating to the latest lockfileVersion (3) which is used by npm v7+ (compare here) - Foreman uses on npm 10 at the time.
Revert previour try to fix the dependabot npm version #108.