Improve error handling and edge cases of UnitInputSelection #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use binary representation for host resources like memory and disk space. However, the UI shows "GB" instead of "GiB" which is actually used.
bastian-src
changed the title
Thorben-D
approved these changes
Feb 11, 2025
The React component 'UnitInputField' prints an error if a user wants to type a value which is a float in the corresponding base unit, for example 5.5 MiB for the memory limit. Instead of showing an error, we introduce a warning which says that the value is rounded to the next lower value (5.0 MiB).
bastian-src
force-pushed
the
fix/unit_selection_and_types
branch
from
b1808a5 to
96af3f1
Compare
* Add snapshots covering default params and disabled view * Add interactive tests to verify onChange and input validation functions are called
bastian-src
force-pushed
the
fix/unit_selection_and_types
branch
from
96af3f1 to
e149671
Compare
|
@maximiliankolb @Thorben-D thanks a lot for your review! 🐧 @Thorben-D I've attached some tests, could you have another look and let me know if you think anything might be missing? |
Thorben-D
approved these changes
Feb 11, 2025
|
Thanks @Thorben-D! 🐠 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves three issues with the React component
UnitInputFieldwhich is used when typing the resource limits of a Resource Quota.From error to floor warning
The UnitInputField prints an error if a user wants to type a value which is a float in the corresponding base unit, for example 5.5 MiB for the memory limit.
Instead of showing an error, we introduce a warning which says that the value is rounded to the next lower value (5.0 MiB):
Before
New
No more natural
Moreover, we introduce a more generic error message if no number is given (removing the word 'natural' as it is quite mathematical/technical):
Before
New
Actually, it's Mebi
We are internally using MebiBytes (MiB) for memory and disk space. However, the UI stated "MB" and others.
Before
New