Merge pull request #133 from ATIX-AG/feature/js-linting

Added js lint target

.github/workflows/js_tests.yml

@@ -0,0 +1,28 @@
+name: JavaScript Testing
+on:
+  push:
+    branches:
+      - main
+  pull_request:
+    paths:
+      - 'webpack/**'
+      - 'package.json'
+      - 'package-lock.json'
+      - '.github/workflows/js_tests.yml'
+jobs:
+  test_js:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        node-version: [12, 14]
+    steps:
+      - uses: actions/checkout@v2
+      - name: Setup Node
+        uses: actions/setup-node@v1
+        with:
+          node-version: ${{ matrix.node-version }}
+      - name: Npm install
+        run: npm install
+      - name: Run plugin linter
+        run: npm run lint

package.json

@@ -8,6 +8,7 @@
     "test": "test"
   },
   "scripts": {
+    "lint": "tfm-lint --plugin -d /webpack",
     "test": "echo \"Error: no test specified\" && exit 1",
     "create-react-component": "yo react-domain"
   },

webpack/components/SCCProductPage/SCCProductPage.js

@@ -5,7 +5,7 @@ import { useDispatch } from 'react-redux';
 import { translate as __ } from 'foremanReact/common/I18n';
 import { useForemanModal } from 'foremanReact/components/ForemanModal/ForemanModalHooks';
 import SCCProductView from './components/SCCProductView';
-import EmptySccProducts from './EmptySccProducts';
+import { EmptySccProducts } from './EmptySccProducts';
 import SCCProductPicker from './components/SCCProductPicker';
 import SCCProductPickerModal from './components/SCCProductPickerModal';
 import { SCCPRODUCTPAGE_SUMMARY_MODAL_ID } from './SCCProductPageConstants';
@@ -26,7 +26,7 @@ const SCCProductPage = ({
     setProductToEdit(productId);
   };
 
-  const { setModalOpen, setModalClosed } = useForemanModal({
+  const { setModalOpen } = useForemanModal({
     id: SCCPRODUCTPAGE_SUMMARY_MODAL_ID,
   });
 

webpack/components/SCCProductPage/components/SCCProductPicker/index.js

@@ -50,7 +50,7 @@ const SCCProductPicker = ({
   editProductId,
   handleSubscribeCallback,
 }) => {
-  const [productItems, setProductItems] = useState(
+  const [productItems] = useState(
     uniq(sccProducts.map((p) => p.product_category))
   );
   const [selectedProduct, setSelectedProduct] = useState('');

webpack/components/SCCProductPage/components/SCCProductView/components/SCCRepoView/index.js

@@ -1,3 +1,4 @@
+/* eslint no-nested-ternary: "off" */
 import { foremanUrl } from 'foremanReact/common/helpers';
 import { sprintf, translate as __ } from 'foremanReact/common/I18n';
 
@@ -88,8 +89,7 @@ const SCCRepoView = ({ sccRepos, sccProductId }) => {
         >
           {sprintf(
             __('Repositories (%s/%s)'),
-            sccRepos.filter((r) => r.katello_repository_id !== null)
-              .length,
+            sccRepos.filter((r) => r.katello_repository_id !== null).length,
             sccRepos.length
           )}
         </BadgeToggle>

webpack/components/SCCProductPage/components/SCCProductView/index.js

@@ -129,7 +129,7 @@ const SCCProductView = ({
   };
   const sccProductsClone = cloneDeep(sccProducts);
   // wrap actual iterator function into anonymous function to pass extra parameters
-  const [allProducts, setAllProducts] = useState(
+  const [allProducts] = useState(
     sccProductsClone.map((tree) =>
       setupTreeViewListItem(tree, true, editProductTree)
     )