Add Zeitwerk loader support

[nadjaheitmann]

No description provided.

[nadjaheitmann]

I don't think that we will get the CI to be green as it is right now because Zeitwerk support is not backwards compatible. We can either add feature branches we can test against or drop the tests. Any other ideas? @dosas @m-bucher @maximiliankolb

[dosas]

I do not get why the tests are failing due to backwards compatibility since the failing tests are all for ruby >=3.

Dropping the tests is not an option.

[nadjaheitmann]

I do not get why the tests are failing due to backwards compatibility since the failing tests are all for ruby >=3.

It is because I adjusted to work foreman_snapshot_management master branch to work Foreman develop which uses Zeitwerk. But Zeitwerk is not used for Foreman 3.11 and 3.12 . Hence, this is a breaking change.

The pipeline always checks against the master branch of this foreman_snapshot_management, no matter what happens in upstream Foreman. So the problem is that the pipeline somehow expect that the plugin is always backwards compatible which it is not. And what is okay, I think, the same happens for all upstream plugins.

[dosas]

I do not get why the tests are failing due to backwards compatibility since the failing tests are all for ruby >=3.

It is because I adjusted to work foreman_snapshot_management master branch to work Foreman develop which uses Zeitwerk. But Zeitwerk is not used for Foreman 3.11 and 3.12 . Hence, this is a breaking change.

The pipeline always checks against the master branch of this foreman_snapshot_management, no matter what happens in upstream Foreman. So the problem is that the pipeline somehow expect that the plugin is always backwards compatible which it is not. And what is okay, I think, the same happens for all upstream plugins.

In that case everything is working as expected (develop: green, 3.11 and 3.12: red)
I would opt for feature branches until 3.13 is released.

[nadjaheitmann]

In that case everything is working as expected (develop: green, 3.11 and 3.12: red)

Definitely, we just need to decide how to deal with that.

I would opt for feature branches until 3.13 is released.

I would suggest to bump a version before merging this and then add a feature branch 3.0-stable .

[nadjaheitmann]

In that case everything is working as expected (develop: green, 3.11 and 3.12: red)

Definitely, we just need to decide how to deal with that.

I would opt for feature branches until 3.13 is released.

I would suggest to bump a version before merging this and then add a feature branch 3.0-stable .

Actually, there are no significant new features, so we probably do not need to bump a new version. I added a new branch for foreman_snapshot_management version 3.x.x which does not run tests on the develop branch https://github.com/ATIX-AG/foreman_snapshot_management/tree/3.0-stable.