Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use theforeman github actions for ruby testing #98

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Use theforeman github actions for ruby testing #98

merged 1 commit into from
Mar 7, 2024

Conversation

dosas
Copy link
Contributor

@dosas dosas commented Feb 20, 2024 •
edited
Loading

@dosas dosas marked this pull request as draft February 20, 2024 14:32
@dosas dosas force-pushed the foreman-actions branch 4 times, most recently from 54bfea3 to c31e4fb Compare February 22, 2024 10:48
@dosas dosas requested review from evgeni and m-bucher and removed request for evgeni March 7, 2024 13:16
@dosas dosas marked this pull request as ready for review March 7, 2024 13:16
@dosas dosas requested a review from evgeni March 7, 2024 13:16
evgeni
evgeni reviewed Mar 7, 2024
View reviewed changes
evgeni
evgeni reviewed Mar 7, 2024
View reviewed changes
evgeni
evgeni approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@evgeni evgeni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some nitpicks, but nothing that makes this not work as intended, so ack

@dosas dosas force-pushed the foreman-actions branch from 2c8e548 to ecab6e6 Compare March 7, 2024 13:31
ekohl
ekohl reviewed Mar 7, 2024
View reviewed changes
Gemfile
@@ -4,5 +4,6 @@ source 'https://rubygems.org'

gemspec

gem "rake", "~> 13.1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd pin it to a .y version to allow updates to 13.2 for example.

Suggested change
gem "rake", "~> 13.1.0"
gem "rake", "~> 13.1"

m-bucher
m-bucher approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@m-bucher m-bucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@m-bucher m-bucher merged commit fa612f0 into master Mar 7, 2024
38 checks passed
@m-bucher m-bucher deleted the foreman-actions branch March 7, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl left review comments

@evgeni evgeni evgeni approved these changes

@m-bucher m-bucher m-bucher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dosas @evgeni @ekohl @m-bucher