Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix on Estimate and some refactoring #258

Merged
merged 15 commits into from
Oct 31, 2020
Merged

Bug fix on Estimate and some refactoring #258

merged 15 commits into from
Oct 31, 2020

Conversation

OngDeZhi
Copy link
Collaborator

@OngDeZhi OngDeZhi commented Oct 31, 2020 •
edited
Loading

Added more checks and bug fix on:

  1. WatchlistParser.
  2. EstimateParser.

Refactor:

  1. Main.
  2. WatchlistCommand.

Update:

  1. UG for better clarity.
  2. JavaDocs.

Fixes #240 and #242

OngDeZhi added 14 commits October 30, 2020 19:03
@OngDeZhi
Merge branch 'master' into OngDeZhi-Estimate
1f8b46e
@OngDeZhi
Bug fix on workspace loading with empty watchlist
cbdeefe
@OngDeZhi
Bug fix on estimate command to accept file names with spaces
b1a2b2d
@OngDeZhi
Merge branch 'master' into OngDeZhi-Estimate
503864c
@OngDeZhi
Update UG on estiamate feature for better clarity
e012750
@OngDeZhi
Fix phrasing and diagram in UG
193de60
@OngDeZhi
Update UG diagram
14961b5
@OngDeZhi
Update JavaDoc and variable naming to be consistent
af41492
@OngDeZhi
Rename option to parameter, updated method name and variable names, a…
947a3eb 
…nd added fix for bugs
@OngDeZhi
Rename option to parameter
2649089
@OngDeZhi
Merge branch 'master' into OngDeZhi-Estimate
bf58877 
# Conflicts:
# src/main/java/anichan/Main.java

Retained changes from upstream branch.
Refactored Main.
@OngDeZhi
Updated input.txt and EXPECTED.TXT
91efde3
@OngDeZhi
Fix language
711e2bf
@OngDeZhi
Fix phrasing
80c3e4b
@OngDeZhi OngDeZhi added this to the V2.1 milestone Oct 31, 2020
@OngDeZhi OngDeZhi added severity.Low A flaw that is unlikely to affect normal operations of the product. Appears only in very rare situat type.Bug A bug labels Oct 31, 2020
@OngDeZhi OngDeZhi linked an issue Oct 31, 2020 that may be closed by this pull request
[PE-D] AY2021S1-CS2113T-F12-2 - Unable to use Estimate feature #242
Closed
@codecov
Copy link

codecov bot commented Oct 31, 2020 •
edited
Loading

Codecov Report

Merging #258 into master will decrease coverage by 0.16%.
The diff coverage is 50.92%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #258      +/-   ##
============================================
- Coverage     76.25%   76.08%   -0.17%     
- Complexity      489      499      +10     
============================================
  Files            47       47              
  Lines          1815     1844      +29     
  Branches        174      183       +9     
============================================
+ Hits           1384     1403      +19     
- Misses          369      379      +10     
  Partials         62       62
Impacted Files Coverage Δ Complexity Δ
src/main/java/anichan/Main.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
.../main/java/anichan/parser/ViewWatchlistParser.java 65.21% <0.00%> (ø) 4.00 <0.00> (ø)
src/main/java/anichan/storage/UserStorage.java 63.33% <ø> (ø) 8.00 <0.00> (ø)
...rc/main/java/anichan/storage/WatchlistStorage.java 100.00% <ø> (ø) 30.00 <0.00> (ø)
src/main/java/anichan/storage/Storage.java 80.95% <50.00%> (ø) 5.00 <1.00> (ø)
...c/main/java/anichan/commands/WatchlistCommand.java 95.83% <87.50%> (ø) 26.00 <1.00> (ø)
...main/java/anichan/parser/AddToWatchlistParser.java 82.60% <100.00%> (ø) 6.00 <0.00> (ø)
src/main/java/anichan/parser/BookmarkParser.java 100.00% <100.00%> (ø) 26.00 <4.00> (ø)
src/main/java/anichan/parser/BrowseParser.java 100.00% <100.00%> (ø) 18.00 <0.00> (ø)
src/main/java/anichan/parser/CommandParser.java 91.66% <100.00%> (-8.34%) 12.00 <2.00> (+1.00) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ced040...6da6901. Read the comment docs.

@OngDeZhi OngDeZhi added the type.Enhancement An enhancement to an existing story label Oct 31, 2020
EyoWeiChin
EyoWeiChin approved these changes Oct 31, 2020
View reviewed changes
Copy link
Collaborator

@EyoWeiChin EyoWeiChin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring Main, looks neater now!

ChanJianHao
ChanJianHao approved these changes Oct 31, 2020
View reviewed changes
Copy link
Collaborator

@ChanJianHao ChanJianHao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@OngDeZhi OngDeZhi merged commit edb6672 into AY2021S1-CS2113T-F12-2:master Oct 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EyoWeiChin EyoWeiChin EyoWeiChin approved these changes

@ChanJianHao ChanJianHao ChanJianHao approved these changes

Assignees
No one assigned
Labels
severity.Low A flaw that is unlikely to affect normal operations of the product. Appears only in very rare situat type.Bug A bug type.Enhancement An enhancement to an existing story
Projects
None yet
Milestone
V2.1
Development

Successfully merging this pull request may close these issues.

[PE-D] AY2021S1-CS2113T-F12-2 - Unable to use Estimate feature [PE-D] estimate feature fails to work
3 participants
@OngDeZhi @EyoWeiChin @ChanJianHao