Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PE-D][Tester C] Persons with same name are considered duplicate #79

Closed
nus-pe-script opened this issue Apr 5, 2024 · 2 comments · Fixed by #141
Closed

[PE-D][Tester C] Persons with same name are considered duplicate #79

nus-pe-script opened this issue Apr 5, 2024 · 2 comments · Fixed by #141
Assignees
Labels
PE-D.Good Good bug report by PE-D tester priority.High Extra attention is needed severity.High Flaw that affects most users and make the product almost unusable for most users type.Bug Something isn't working
Milestone

Comments

@nus-pe-script
Copy link

HackLink recognises two people as duplicates if the name is the same, even if the other contact informations are different. This may pose an issue as it is highly possible for participants to have the same name.

For example, ap n/Davian p/84889861 e/[email protected] successfully creates a participant, but ap n/Davian p/87654321 e/[email protected] will fail to add as a different participant as he is recognised as an existing person.

Perhaps, a person's name, phone number and email can be compared to determine if he is indeed a duplicate.
Screenshot 2024-04-05 at 4.27.34 PM.png


Labels: severity.High type.FeatureFlaw
original: NatLeong/ped#2

@bachletuankhai bachletuankhai self-assigned this Apr 6, 2024
@bachletuankhai bachletuankhai added this to the v1.4 milestone Apr 6, 2024
@bachletuankhai
Copy link

  • descriptive title: ✔️
  • enough details: ✔️
  • severity/type labels chosen are not too far off: ✔️
  • non-confrontational tone: ✔️
  • points out a potentially problematic behavior (or a good way to improve the product): ✔️

Good report

@bachletuankhai
Copy link

Should use person name and phone number to differentiate between people. It is possible that 1 person has 2 or more phone numbers, but 2 person cannot have the same phone number. This will be enough for allowing people with same name to be entered into the database, but preventing possible duplicate contacts.

@bachletuankhai bachletuankhai added type.Bug Something isn't working priority.High Extra attention is needed severity.Medium Flaw that causes occasional inconvenience to some users PE-D.Good Good bug report by PE-D tester severity.High Flaw that affects most users and make the product almost unusable for most users and removed severity.Medium Flaw that causes occasional inconvenience to some users labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PE-D.Good Good bug report by PE-D tester priority.High Extra attention is needed severity.High Flaw that affects most users and make the product almost unusable for most users type.Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants