Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update equality check for person #351

Conversation

Shruthiiii03
Copy link

2 students are now considered the same person only if they are in the same class and have the same register number.
Fixes #258

@Shruthiiii03 Shruthiiii03 added this to the v1.6 milestone Nov 11, 2024
@Shruthiiii03 Shruthiiii03 self-assigned this Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
...c/main/java/seedu/address/model/person/Person.java 98.76% <100.00%> (+0.04%) 42.00 <6.00> (+2.00)

... and 1 file with indirect coverage changes

Copy link

@gohqingkhang gohqingkhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but someone else to check also, as need to be more careful about codebase change

@gohqingkhang gohqingkhang merged commit 227e7f7 into AY2425S1-CS2103-F12-4:master Nov 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester B] Multiple people allowed with same name
3 participants