Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Branch resolve wrong error message #358

Conversation

gohqingkhang
Copy link

@gohqingkhang gohqingkhang commented Nov 11, 2024

Resolves #298

Command to run:
addSubmissionStatus sm/A1 ss/Y

Original error message received:
Index is not a non-zero unsigned integer.

This error message is wrong as the error is not that the index given is a non-zero integer, but rather that the index was not given in the first place.

Corrected error message:

Invalid command format!
addSubmissionStatus: Adds a submission status to a student identified by index.
Parameters: [INDEX] sm/SUBMISSION_NAME ss/SUBMISSION_STATUS
Example: addSubmissionStatus 1 sm/Assignment 1 ss/Y

Similar error messages provided for addExamScore, addAttendance, addEcName and addEcNumber commands are amended as well.

@gohqingkhang gohqingkhang added this to the v1.6 milestone Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ Complexity Δ
...dress/logic/parser/AddAttendanceCommandParser.java 100.00% <100.00%> (ø) 6.00 <0.00> (+1.00)
...u/address/logic/parser/AddEcNameCommandParser.java 88.88% <100.00%> (-11.12%) 5.00 <0.00> (+1.00) ⬇️
...address/logic/parser/AddEcNumberCommandParser.java 85.71% <100.00%> (+2.38%) 4.00 <0.00> (+1.00)
...ddress/logic/parser/AddExamScoreCommandParser.java 100.00% <100.00%> (ø) 5.00 <0.00> (+1.00)
...logic/parser/AddSubmissionStatusCommandParser.java 100.00% <100.00%> (ø) 6.00 <0.00> (+1.00)

Copy link

@BunnyHoppp BunnyHoppp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BunnyHoppp BunnyHoppp merged commit 75b1240 into AY2425S1-CS2103-F12-4:master Nov 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PE-D][Tester B] Wrong error message for no index
2 participants