Fix rejecting invalid ecNumber inputs #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EcNumber can now take in numbers with 3 digits or more, since some phone numbers can be more than 8 digits or less than 8 digits.
Update documentation to accept numbers that are at least 3 digits
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addEcNumber command can only accept 8 digit numbers, and would reject numbers that has less or more than 8 digits. There are some phone numbers that might be less than or more than 8 digits that are valid phone numbers.
Fixed addEcNumber to accept numbers with at least 3 digits, as to not reject valid inputs.
Error message is then incorrect. Error message is updated accordingly in the same commit 1ca2389.
Fixes #309.