post-merge fixes

AbsaOSS · Jan 22, 2024 · fe918df · fe918df
1 parent 2ab9fd5
commit fe918df
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 6 deletions.
diff --git a/agent/src/main/scala/za/co/absa/atum/agent/model/MeasurementBuilder.scala b/agent/src/main/scala/za/co/absa/atum/agent/model/MeasurementBuilder.scala
@@ -24,7 +24,7 @@ import za.co.absa.atum.model.dto.{MeasureDTO, MeasureResultDTO, MeasurementDTO}
  */
 private [agent] object MeasurementBuilder {
 
-  private def validateMeasurement(measure: Measure, result: MeasureResult): Unit = {
+  private def validateMeasurement(measure: AtumMeasure, result: MeasureResult): Unit = {
     val actualType = result.resultType
     val requiredType = measure.resultValueType
 
@@ -58,7 +58,19 @@ private [agent] object MeasurementBuilder {
 
   private[agent] def buildMeasurementDTO(measure: Measure, measureResult: MeasureResult): MeasurementDTO = {
     val measureName = measure.measureName
-    val measuredColumns = Seq(measure.measuredColumns)
+    val measuredColumns = measure.measuredColumns
+
+    val measureDTO = MeasureDTO(measureName, measuredColumns)
+    val measureResultDTO = MeasureResultDTO(
+      MeasureResultDTO.TypedValue(measureResult.resultValue.toString, measureResult.resultType)
+    )
+    MeasurementDTO(measureDTO, measureResultDTO)
+  }
+
+  // TODO Measure vs AtumMeasure
+  private[agent] def buildMeasurementDTO(measure: AtumMeasure, measureResult: MeasureResult): MeasurementDTO = {
+    val measureName = measure.measureName
+    val measuredColumns = measure.measuredColumns
 
     validateMeasurement(measure, measureResult)
 

diff --git a/agent/src/test/scala/za/co/absa/atum/agent/model/MeasurementBuilderTest.scala b/agent/src/test/scala/za/co/absa/atum/agent/model/MeasurementBuilderTest.scala
@@ -19,7 +19,7 @@ package za.co.absa.atum.agent.model
 import org.scalatest.flatspec.AnyFlatSpec
 import za.co.absa.atum.agent.exception.AtumAgentException.MeasurementException
 import za.co.absa.atum.model.dto.{MeasureDTO, MeasureResultDTO, MeasurementDTO}
-import za.co.absa.atum.agent.model.AtumMeasure.SumOfValuesOfColumn
+import za.co.absa.atum.agent.model.AtumMeasure._
 import za.co.absa.atum.model.dto.MeasureResultDTO.{ResultValueType, TypedValue}
 
 class MeasurementBuilderTest extends AnyFlatSpec {
@@ -111,15 +111,15 @@ class MeasurementBuilderTest extends AnyFlatSpec {
   }
 
   "buildMeasurementDTO" should "throw exception for unsupported result value type for a given Measure" in {
-    val measure = DistinctRecordCount("col")
+    val measure = DistinctRecordCount(Seq("col"))
     val measureResult = MeasureResult("1")
 
     assertThrows[MeasurementException](MeasurementBuilder.buildMeasurementDTO(measure, measureResult))
   }
 
   "buildMeasurementDTO" should "build Seq[MeasurementDTO] for multiple measures, all unique" in {
     val measurements = Set(
-      Measurement(DistinctRecordCount("col"), MeasureResult("1", ResultValueType.Long)),
+      Measurement(DistinctRecordCount(Seq("col")), MeasureResult("1", ResultValueType.Long)),
       Measurement(SumOfValuesOfColumn("col1"), MeasureResult(BigDecimal(1.2))),
       Measurement(SumOfValuesOfColumn("col2"), MeasureResult(BigDecimal(1.3)))
     )
@@ -142,7 +142,7 @@ class MeasurementBuilderTest extends AnyFlatSpec {
 
   "buildMeasurementDTO" should "throw exception for multiple measures, some of them repetitive" in {
     val measurements = Set(
-      Measurement(DistinctRecordCount("col"), MeasureResult("1")),
+      Measurement(DistinctRecordCount(Seq("col")), MeasureResult("1")),
       Measurement(SumOfValuesOfColumn("col"), MeasureResult(BigDecimal(1.2))),
       Measurement(SumOfValuesOfColumn("col"), MeasureResult(BigDecimal(1.3)))
     )