#353 Register Denodo dialect via Denodo SQL generator when it is firs…

…t used.
AbsaOSS · Feb 15, 2024 · 705c1e6 · 705c1e6
1 parent cda8efb
commit 705c1e6
Show file tree

Hide file tree

Showing 5 changed files with 22 additions and 4 deletions.
diff --git a/pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorDenodo.scala b/pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorDenodo.scala
@@ -16,14 +16,32 @@
 
 package za.co.absa.pramen.core.sql
 
+import org.apache.spark.sql.jdbc.JdbcDialects
+import org.slf4j.LoggerFactory
 import za.co.absa.pramen.api.sql.{SqlColumnType, SqlConfig, SqlGeneratorBase}
+import za.co.absa.pramen.core.sql.dialects.DenodoDialect
 
 import java.time.LocalDate
 import java.time.format.DateTimeFormatter
 
+object SqlGeneratorDenodo {
+  private val log = LoggerFactory.getLogger(this.getClass)
+
+  /**
+    * This is required for Spark to be able to handle data that comes from Denodo JDBC drivers
+    */
+  lazy val registerDialect: Boolean = {
+    log.info(s"Registering Denodo dialect...")
+    JdbcDialects.registerDialect(DenodoDialect)
+    true
+  }
+}
+
 class SqlGeneratorDenodo(sqlConfig: SqlConfig) extends SqlGeneratorBase(sqlConfig) {
   private val dateFormatterApp = DateTimeFormatter.ofPattern(sqlConfig.dateFormatApp)
 
+  SqlGeneratorDenodo.registerDialect
+
   override val beginEndEscapeChars: (Char, Char) = ('\"', '\"')
 
   override def getDtable(sql: String): String = {

diff --git a/pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorHive.scala b/pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorHive.scala
@@ -19,7 +19,7 @@ package za.co.absa.pramen.core.sql
 import org.apache.spark.sql.jdbc.JdbcDialects
 import org.slf4j.LoggerFactory
 import za.co.absa.pramen.api.sql.{SqlColumnType, SqlConfig, SqlGeneratorBase}
-import za.co.absa.pramen.core.sql.impl.HiveDialect
+import za.co.absa.pramen.core.sql.dialects.HiveDialect
 
 import java.time.LocalDate
 import java.time.format.DateTimeFormatter

diff --git a/pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorSas.scala b/pramen/core/src/main/scala/za/co/absa/pramen/core/sql/SqlGeneratorSas.scala
@@ -19,7 +19,7 @@ package za.co.absa.pramen.core.sql
 import org.apache.spark.sql.jdbc.JdbcDialects
 import org.slf4j.LoggerFactory
 import za.co.absa.pramen.api.sql.{SqlColumnType, SqlConfig, SqlGeneratorBase}
-import za.co.absa.pramen.core.sql.impl.SasDialect
+import za.co.absa.pramen.core.sql.dialects.SasDialect
 
 import java.sql.{Connection, ResultSet}
 import java.time.LocalDate

diff --git a/...sa/pramen/core/sql/impl/HiveDialect.scala → ...ramen/core/sql/dialects/HiveDialect.scala b/...sa/pramen/core/sql/impl/HiveDialect.scala → ...ramen/core/sql/dialects/HiveDialect.scala
@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-package za.co.absa.pramen.core.sql.impl
+package za.co.absa.pramen.core.sql.dialects
 
 import org.apache.spark.sql.jdbc.JdbcDialect
 import org.apache.spark.sql.types.{DataType, MetadataBuilder}

diff --git a/...bsa/pramen/core/sql/impl/SasDialect.scala → ...pramen/core/sql/dialects/SasDialect.scala b/...bsa/pramen/core/sql/impl/SasDialect.scala → ...pramen/core/sql/dialects/SasDialect.scala
@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-package za.co.absa.pramen.core.sql.impl
+package za.co.absa.pramen.core.sql.dialects
 
 import org.apache.spark.sql.jdbc.JdbcDialect
 import org.apache.spark.sql.types.{DataType, MetadataBuilder}