fix(wheels): Ensure python-based builds use maj.min.patch SO versioning #4634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always use patch-specific SO versioning for scikit-build-core-based builds, even when OpenImageIO_SUPPORTED_RELEASE=ON. Fixes AcademySoftwareFoundation#4621 Signed-off-by: Zach Lewis <[email protected]>
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Feb 14, 2025
…ng (AcademySoftwareFoundation#4634) Always use patch-specific SO versioning for scikit-build-core-based builds, even when OpenImageIO_SUPPORTED_RELEASE=ON. Fixes AcademySoftwareFoundation#4621 Ensures that Python-based builds only bundle a single copy each of libOpenImageIO and libOpenImageIO_Util shared libraries. ## Tests Previously, `$ uv sync -v --reinstall -Ccmake.define.OpenImageIO_SUPPORTED_RELEASE=1` would bundle both .so.3.0 and .so.3.0.3 copies of libraries when installing to a local virtual environment. With this fix, only .so.3.0.3 copies of libraries are installed. Signed-off-by: Zach Lewis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always use patch-specific SO versioning for scikit-build-core-based builds, even when OpenImageIO_SUPPORTED_RELEASE=ON.
Fixes #4621
Description
Ensures that Python-based builds only bundle a single copy each of libOpenImageIO and libOpenImageIO_Util shared libraries.
Tests
Previously,
$ uv sync -v --reinstall -Ccmake.define.OpenImageIO_SUPPORTED_RELEASE=1would bundle both .so.3.0 and .so.3.0.3 copies of libraries when installing to a local virtual environment.With this fix, only .so.3.0.3 copies of libraries are installed.