test: image_span_test reduce benchmark load for debug and CI renders #4951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Almost all the other unit tests do this, just adding it to image_span_test: automatic reduction in test load for CI and debug renders by doing fewer time trials. This cuts down on runtime for CI, but stil exercises the test code. Command line arguments allow you to override, in cases where you need really good timing fidelity even for a debug run. Signed-off-by: Larry Gritz <[email protected]>
Collaborator
Author
|
Need this right away to address some CI issues. Will merge shortly if there are no objections. The code changes here are only to unit tests. |
jessey-git
reviewed
Nov 11, 2025
| using namespace OIIO; | ||
|
|
||
|
|
||
| static int iterations = 0; // 1000000; |
Contributor
There was a problem hiding this comment.
Looks like iterations is unused. It's only set, but never passed into something like bench.iterations(...)
| "image_span_test -- unit test and benchmarks for OpenImageIO/image_span.h\n" OIIO_INTRO_STRING) | ||
| .usage("image_span_test [options]"); | ||
|
|
||
| ap.arg("--iterations %d", &iterations) |
Contributor
There was a problem hiding this comment.
Funny stat: There's currently 14 instances of tests that use --iters and 14 instances that use --iterations. This new addition here would tip the scale in favor of using the full --iterations name -- should somebody make them all the same and create a new PR for that?
[EDIT] Actually I miscounted, there's just 1 other test, simd_test.cpp that uses the full --iterations name.
Collaborator
Author
There was a problem hiding this comment.
Aha, fixing simd_test
lgritz
force-pushed
the
lg-imagespantest
branch
from
912fca1 to
f072ea0
Compare
…usual standard used elsewhere Signed-off-by: Larry Gritz <[email protected]>
lgritz
force-pushed
the
lg-imagespantest
branch
from
f072ea0 to
2f55227
Compare
jessey-git
approved these changes
Nov 11, 2025
lgritz
merged commit 72d7991
into
AcademySoftwareFoundation:main
28 of 30 checks passed
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Nov 13, 2025
…cademySoftwareFoundation#4951) Almost all the other unit tests do this, just adding it to image_span_test: automatic reduction in test load for CI and debug renders by doing fewer time trials. This cuts down on runtime for CI, but stil exercises the test code. Command line arguments allow you to override, in cases where you need really good timing fidelity even for a debug run. Also conform simd_test to the usual standard `-iters` used elsewhere instead of being the one place that uses `-iterations`. --------- Signed-off-by: Larry Gritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Almost all the other unit tests do this, just adding it to image_span_test: automatic reduction in test load for CI and debug renders by doing fewer time trials. This cuts down on runtime for CI, but stil exercises the test code. Command line arguments allow you to override, in cases where you need really good timing fidelity even for a debug run.