Feature/Qt6 - Fix issue with QItemSelectionModel::select method in Mu #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cédrik Fuoco <[email protected]>
cedrik-fuoco-adsk
requested review from
bernie-laberge and
eloisebrosseau
as code owners
eloisebrosseau
approved these changes
Feb 13, 2025
cedrik-fuoco-adsk
merged commit 8cb8ab9
into
AcademySoftwareFoundation:feature/qt6
20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature/Qt6 - Fix issue with QItemSelectionModel::select method in Mu
Linked issues
n/a
Summarize your change.
Added a special case to deal with calls to
QItemSelectionModel::select.Describe the reason for the change.
The new implementation of
QMetaMethod:invokein Qt 6 is using variadic templates and C++ type deduction (instead ofQGenericArgument). Therefore, it does not convert theQItemSelectionModel::SelectionFlagsenum tointand an error message appears.Describe what you have tested and on which operating system.
Rocky 8 and MacOS