Feature/Qt6 - Rebase main into feature/qt6 #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedrik-fuoco-adsk
requested review from
bernie-laberge and
eloisebrosseau
as code owners
### Add missing rvSession.py ### Linked issues NA ### Describe the reason for the change. This python file module was unfortunately forgotten when RV was open sourced. ### Summarize your change. I removed the duplicated gtoContainer.py file module (duplication is bad) and made the necessary adjustments to the CMake build system to install it when building Open RV. ### Describe what you have tested and on which operating system. Successfully testes on macOS. ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. Signed-off-by: Bernard Laberge <[email protected]> Signed-off-by: Cédrik Fuoco <[email protected]>
…#668) Add Support for the Cannon Raw 3 File Type ### Summarize your change. Added support for OpenRV to read cr3 files. ### Describe the reason for the change. This allows OpenRV to read cr3 files which is becoming more common as it is intended to replace cr2. ### Describe what you have tested and on which operating system. I have tested this on both Windows 11 and AlmaLinux 9 by loading a cr3 file in OpenRV. ### Add a list of changes, and note any that might need special attention during the review. Since this is something supported by the version of libraw that OpenRV is currently using, it is as simple as just adding another type to the IORaw.cpp file. ### If possible, provide screenshots.  --------- Signed-off-by: Christopher Lee <[email protected]> Co-authored-by: Bernard Laberge <[email protected]> Signed-off-by: Cédrik Fuoco <[email protected]>
Set OpenRV version to 2.2.0 Signed-off-by: Bernard Laberge <[email protected]> Signed-off-by: Cédrik Fuoco <[email protected]>
…oundation#686) ### Prevent 'ERROR: Unable to determine aspect ratio…' when loading OTIO with multiple media representations ### Linked issues NA ### Describe the reason for the change. To fix the following error when loading OTIO with multiple media representations 'ERROR: Unable to determine aspect ratio…' ### Summarize your change. When multiple media representation sources are created, we can only retrieve the media_info of a source if it is the active source. That's because multiple media representation in Open RV is optimized to only load a source when it gets activated. If the current source is not the active source, we can't get the media_info so we fall back to the active source's media_info as our best guess. ### Describe what you have tested and on which operating system. Successfully tested on macOS ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. Signed-off-by: Bernard Laberge <[email protected]> Signed-off-by: Cédrik Fuoco <[email protected]>
### Add missing RV network python module
### Linked issues
NA
### Describe the reason for the change.
This python module was unfortunately forgotten when RV was open sourced.
### Summarize your change.
I moved the RV network python module files one sub-directory under their
current location in order to be able to use the
RV_STAGE("PYTHON_SOURCE_MODULE" FILES network_driectory) Cmake macro to
install and made the necessary adjustments to the CMake build system to
install it when building Open RV.
With this commit, once built, the RV network python module files will be
under the
RV.app/Contents/PlugIns/Python/network directory.
### Describe what you have tested and on which operating system.
Successfully testes on macOS.
### Add a list of changes, and note any that might need special
attention during the review.
### If possible, provide screenshots.
Signed-off-by: Bernard Laberge <[email protected]>
Signed-off-by: Cédrik Fuoco <[email protected]>
cedrik-fuoco-adsk
force-pushed
the
qt6-rebase-feb13
branch
from
60f48d2 to
d0d61ba
Compare
cedrik-fuoco-adsk
merged commit 5c88495
into
AcademySoftwareFoundation:feature/qt6
19 of 20 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature/Qt6 - Rebase main into feature/qt6
Linked issues
n/a
Summarize your change.
Rebase main into feature/qt6