Replace CMake generated version files with checked-in versions#1993
Conversation
meshula
left a comment
There was a problem hiding this comment.
looking good, minor request
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1993 +/- ##
=======================================
Coverage 85.15% 85.15%
=======================================
Files 181 181
Lines 12783 12783
Branches 1206 1206
=======================================
Hits 10885 10885
Misses 1715 1715
Partials 183 183
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Sorry, I don't know how I typed 4 #'s in a row. I'm still in favor of concatenation even with a helpy macro! |
That requires updating every source file with the new macro. That seems like a lot of work to not duplicate a number, plus it also adds complexity which I think undermines the benefits of DRY. |
|
Trying this PR out on the Swift bindings here: OpenTimelineIO/OpenTimelineIO-Swift-Bindings#78 |
AcademySoftwareFoundation/OpenTimelineIO#1993 Signed-off-by: Joshua Minor <jminor@users.noreply.github.com>
|
This seems to be working well for the Swift bindings. Related: I noticed one typo in the README.md which says but I think it should be |
|
Good catch, I updated the example code to use our namespace macro |
|
Oh cool. I'll update the Swift bindings to use that macro too. @meshula are you okay if we skip your suggestion about the ## macro concatenation? |
meshula
left a comment
There was a problem hiding this comment.
fancy macros don't block merging, thanks for the PR!
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
Signed-off-by: Darby Johnston <darbyjohnston@yahoo.com>
a79ed3d to
0bb458e
Compare
2314a61
into
AcademySoftwareFoundation:main
In PR #1907 we added version headers so applications could identify which OpenTimelineIO they were using. However this also introduced a dependency on CMake to generate the headers, which can cause issues for other projects that use OTIO without CMake (for example the OTIO Swift bindings).
This PR replaces the CMake file generation with checked-in files, and instead has CMake parse the version from the checked-in header files. This is similar to what OpenEXR does for their version handling.