Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

estimateGas supports blocktag #894

Merged
merged 4 commits into from
Dec 4, 2023
Merged

estimateGas supports blocktag #894

merged 4 commits into from
Dec 4, 2023

Conversation

shunjizhan
Copy link
Collaborator

@shunjizhan shunjizhan commented Dec 4, 2023 •
edited
Loading

Change

eth_estimateGas now supports blocktag as second param

fix #854
fix #891

Test

added tests to make sure passing "latest" returns same result as not passing blocktag

@shunjizhan shunjizhan requested a review from zjb0807 December 4, 2023 05:53
@shunjizhan shunjizhan marked this pull request as ready for review December 4, 2023 05:53
@shunjizhan shunjizhan marked this pull request as draft December 4, 2023 06:05
@shunjizhan shunjizhan removed the request for review from zjb0807 December 4, 2023 06:08
@shunjizhan shunjizhan requested a review from zjb0807 December 4, 2023 06:39
@shunjizhan shunjizhan marked this pull request as ready for review December 4, 2023 06:40
@shunjizhan shunjizhan merged commit 0451b70 into master Dec 4, 2023
11 checks passed
@shunjizhan shunjizhan deleted the estimategas-with-blocktag branch December 4, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjb0807 zjb0807 zjb0807 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remix estimate gas failed eth_estimateGas should accept blocktag params
2 participants
@shunjizhan @zjb0807