throw outOfGas error when gaslimit too low
#899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shunjizhan
changed the title
outOfGas error when gaslimit too low
zjb0807
approved these changes
Dec 7, 2023
| @@ -826,7 +822,7 @@ export abstract class BaseProvider extends AbstractProvider { | |||
| const api = at ? await this.api.at(at) : this.api; | |||
|
|
|||
| const { from, to, gasLimit, storageLimit, value, data, accessList } = callRequest; | |||
| const estimate = true; | |||
| const estimate = false; | |||
There was a problem hiding this comment.
the estimate is not used in API.
There was a problem hiding this comment.
cool, I think I changed that when randomly trying things out lol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
throws
outOfGaserror when:gasparam is too small when callingeth_calloreth_estimateGasRPCgasLimitoverride is too small when sending transactionalso cleaned up
getTransactionRequest, it now has more concise logic, and will auto transformgastogasLimitif presentfix #895
Test
added tests for all cases mentioned above