Bakesy

[elle-johnnie]

bEtsy

Congratulations! You're submitting your assignment! These comprehension questions should be answered by all members of your team, not by a single teammate.

Comprehension Questions

Question	Answer
Each team member: what is one thing you were primarily responsible for that you're proud of?	Laura: checkout process, Jazz: session tests when not every user logs in, Trang: Shopping Cart works and helped her understand session integration, Liz: Merchant dashboard functions
Each team member: what is one thing you were primarily responsible for that you would like targeted feedback on?	Laura: where code should go Jazz:dependencies Trang: tests and how to be Metz compliant Liz: db queries and optimization
How did your team break up the work to be done?	daily stand-ups helped us prioritize
How did your team utilize git to collaborate?	implemented branching of features to minimize major git-tastrophies.
What did your group do to try to keep your code DRY while many people collaborated on it?	we used a method of commenting things out then waiting until the end to clean most of the unused code
What was a technical challenge that you faced as a group?	git merging initially, but we developed a good workflow as we continued with the project
What was a team/personal challenge that you faced as a group?	Understanding how a real-life working situation works when people typically work more independently of each other and handle a major project. We missed a stand-up and that day we all found ourselves struggling a bit that evening to know what to prioritize and accomplish for the day.. In hindsight we realized that we should have done a midpoint huddle to reorganize and check back in on our original plan.
What was your application's ERD? (include a link)	https://www.lucidchart.com/documents/view/0ce65827-ac9c-4f15-b1b7-4f9278f6a9af/0
What is your Trello URL?	https://trello.com/b/PGJtzRSW/bakesy
What is the Heroku URL of your deployed application?	https://bakesy.herokuapp.com/

[elle-johnnie]

Heya Devin, it looks like only part of the feedback form was submitted back to us. Do you have more details on this before I pass it on?

…

On Thu, Nov 8, 2018 at 3:38 PM UGH FINE ***@***.***> wrote: bEtsy What We're Looking For Feature Feedback *Baseline* Appropriate Git Usage with all members contributing yes Answered comprehension questions yes Trello board is created and utilized in project management yes Heroku instance is online yes *General* Nested routes follow RESTful conventions oAuth used for User authentication yes Functionality restricted based on user roles Products can be added and removed from cart Users can look up past orders by ID Merchants can add, edit and view their products Errors are reported to the user *Order Functionality* Reduces products' inventory Cannot order products that are out of stock Changes order state Clears current cart *Database* ERD includes all necessary tables and relationships Table relationships *Models* Validation rules for Models Business logic is in the models *Controllers* Controller Filters used to DRY up controller code *Testing* Model Testing Controller Testing Session Testing SimpleCov at 90% for controller and model tests *Front-end* The app is styled to create an attractive user interface Good, but your dashboard doesn't match the look and feel of the rest of the site. Colors are different, and so are the fonts. Content is organized with HTML5 semantic tags CSS is DRY *Overall* Only the person who submitted the PR will get an email about this feedback. Please let the rest of your team know about it. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#23 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AH0TSrEJJnlkBPF-THOTJPhu5okphC5dks5utMCDgaJpZM4X9G_0> .

[dHelmgren]

Don't pass it on yet! I hit the submit button WAY early so there is a lot more feedback I want to give. Ya'll can expect to see it tomorrow.

…

On Thu, Nov 8, 2018 at 8:57 PM Liz ***@***.***> wrote: Heya Devin, it looks like only part of the feedback form was submitted back to us. Do you have more details on this before I pass it on? On Thu, Nov 8, 2018 at 3:38 PM UGH FINE ***@***.***> wrote: > bEtsy What We're Looking For > Feature Feedback > *Baseline* > Appropriate Git Usage with all members contributing yes > Answered comprehension questions yes > Trello board is created and utilized in project management yes > Heroku instance is online yes > *General* > Nested routes follow RESTful conventions > oAuth used for User authentication yes > Functionality restricted based on user roles > Products can be added and removed from cart > Users can look up past orders by ID > Merchants can add, edit and view their products > Errors are reported to the user > *Order Functionality* > Reduces products' inventory > Cannot order products that are out of stock > Changes order state > Clears current cart > *Database* > ERD includes all necessary tables and relationships > Table relationships > *Models* > Validation rules for Models > Business logic is in the models > *Controllers* > Controller Filters used to DRY up controller code > *Testing* > Model Testing > Controller Testing > Session Testing > SimpleCov at 90% for controller and model tests > *Front-end* > The app is styled to create an attractive user interface Good, but your > dashboard doesn't match the look and feel of the rest of the site. Colors > are different, and so are the fonts. > Content is organized with HTML5 semantic tags > CSS is DRY > *Overall* Only the person who submitted the PR will get an email about > this feedback. Please let the rest of your team know about it. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#23 (comment)>, or mute > the thread > < https://github.com/notifications/unsubscribe-auth/AH0TSrEJJnlkBPF-THOTJPhu5okphC5dks5utMCDgaJpZM4X9G_0 > > . > — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#23 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AFM9zL6YDMBglC_3FEFbqC9xMvlO_nfFks5utQszgaJpZM4X9G_0> .

[dHelmgren]

bEtsy

What We're Looking For

Feature	Feedback
Baseline
Appropriate Git Usage with all members contributing	yes
Answered comprehension questions	yes, though it would have helped me to have more detailed answers to the first two questions. I had a hard time giving targeted feedback because several answers were so vague.
Trello board is created and utilized in project management	yes
Heroku instance is online	yes
General
Nested routes follow RESTful conventions	Yes
oAuth used for User authentication	Yes
Functionality restricted based on user roles	yes
Products can be added and removed from cart	yes
Users can look up past orders by ID	yes
Merchants can add, edit and view their products	yes
Errors are reported to the user	yes
Order Functionality
Reduces products' inventory	Yes
Cannot order products that are out of stock	There's a loophole in your logic that lets people order things that are out of stock, see comments.
Changes order state	Yes
Clears current cart	Yes
Database
ERD includes all necessary tables and relationships	Yes
Table relationships	Yes
Models
Validation rules for Models	Good
Business logic is in the models	Good
Controllers
Controller Filters used to DRY up controller code	yes!
Testing	6 of your tests fail outright and 25 produce errors!
Model Testing	Missing validations on custom logic, see comment.
Controller Testing	Malformed paths in controller tests, see comment.
Session Testing	Good.
SimpleCov at 90% for controller and model tests	No, you're hovering at 85%
Front-end
The app is styled to create an attractive user interface	Yes, but your dashboard has fonts and colors that don't match the rest of the site.
Content is organized with HTML5 semantic tags	There are a lot of semantic tags that could make your HTML much more readable, see comments!
CSS is DRY	Yes
Overall	Given your overall level of work on this project, I would say you are meeting standard. Your project presents itself well and does a good job of preventing basic errors. However, your testing overall leaves a lot to be desired. The number of tests that are not working combined with the low coverage from simplecov means your tests not the level of work that we expect from you. Not to drive the point too hard, but test driven development requires writing tests alongside your code, not after it, and that as things change in your code, you make sure the tests change with them.

Only the person who submitted the PR will get an email about this feedback. Please let the rest of your team know about it.

[dHelmgren]

This would be a really good place to try the <aside> tag!

[dHelmgren]

Things like tasting notes here might be a good candidate for the <details> tag.

[dHelmgren]

Tests for your cart specifically might try:

• Does it handle things being added correctly?
• Do items get removed properly?
• Can I over-order items by having two carts check out the last of a particular item?

[dHelmgren]

categories_index_url is not the correct path name, so none of these tests are doing what you would like them to do, which means your tests don't adequately test your code. Making sure that the named path actually matches the route that you want to call is important! You wanted either categories_path or categories_url

[dHelmgren]

I'm pretty sure that this end is premature, and it breaks every test that follows.

[dHelmgren]

Your create path uses the Post verb, so this test is malformed.

[dHelmgren]

Where are the tests for your custom logic? Most of your models have some sort of custom logic, but the methods aren't getting tested at all.