oo-ride-share-maryam-kay #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded 2 tests for it
…sts creating valid Driver, valid VIN, and valid ID
…river add_driven_trip()modified
…exception in find_driver_by_availability method
…ted tests passing
Ride ShareWhat We're Looking For
|
CheezItMan
reviewed
Sep 6, 2018
|
|
||
| expect(driver).must_be_instance_of RideShare::Driver | ||
|
|
||
| expect(driver.trips).must_include trip |
There was a problem hiding this comment.
Not passing, the expectation should read:
expect(driver.driven_trips).must_include trip
Also see my note in TripDispatcher
| } | ||
|
|
||
| trip = Trip.new(parsed_trip) | ||
| passenger.add_trip(trip) |
There was a problem hiding this comment.
You should also have:
driver.add_driven_trip(trip)| end | ||
| end | ||
| it "establishes the base data structures when instantiated" do | ||
| dispatcher = RideShare::TripDispatcher.new |
There was a problem hiding this comment.
Should have the files used for testing in the arguments to new
dispatcher = RideShare::TripDispatcher.new(USER_TEST_FILE,
TRIP_TEST_FILE, DRIVER_TEST_FILE)| driven_trips.each do |trip| | ||
| all_ratings << trip.rating | ||
| end | ||
| return average = (all_ratings.sum / all_ratings.length).to_f.round(1) |
There was a problem hiding this comment.
You don't need average you could simply:
return (all_ratings.sum / all_ratings.length).to_f.round(1)| end | ||
|
|
||
| def net_expenditures | ||
| return (super - total_revenue) |
| expect(before_new_trip < after_new_trip).must_equal true | ||
| end | ||
|
|
||
| it "makes sure driver is not driving themself " do |
There was a problem hiding this comment.
I would add one test where there is one driver available and that driver requests a trip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OO Ride Share
Congratulations! You're submitting your assignment!
Comprehension Questions
UserandDriver