Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Katricia - Edges - Personal Portfolio Site #34

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

krsmith7
Copy link

Personal Portfolio Site

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Did you have to resolve any issues when running the HTML Validator? If so, what were they? The HTML validator picked up an end tag with a back slash and headings under other headings. The first one I edited to have a proper closing tag.
Why is it important to consider and use semantic HTML? It is important for readability and also for technologies like screen readers which really on semantic HTML to help make sense of the page.
How did you decide to structure your CSS? I structured my CSS in order of the accessed pages. I used descriptive class names as much as possible to better be able to follow the CSS and make changes to specific sections.
What was the most challenging piece of this assignment? I thought I had a grid for most of the pages, then realized later that I had commented out the body grid. It is too easy to have inconsistencies that the program/browser does not give errors for.
Describe one area that you gained more clarity on when completing this assignment Linking pages, images, and stylesheets together.
Optional
Did you deploy to GitHub Pages? If so, what is the URL to your website?
Overall

@droberts-sea
Copy link

Personal Portfolio Site

What We're Looking For

Feature Feedback
Baseline
Appropriate Git Usage yes
Answered comprehension questions yes
Page fully loads yes
No broken links (regular or images) yes
Includes at least 4 pages and styling yes
HTML
Uses the high-level tags for organization: header, footer, main yes
Appropriately using semantic tags: section, article, etc. yes
All images include alternate text yes
CSS
Using class and ID names in style declarations yes
Style declarations are DRY yes
Overall

Good work overall! It's clear to me that the learning goals for this assignment were met.

For this project, the instructors are giving a spot-check review, looking for big patterns rather than going through your code line-by-line. If you’d like a more in-depth review, please reach out to your instructor!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants