Reverse Sentence - Hannah #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrutivanw
reviewed
Nov 19, 2018
| return my_string | ||
| end | ||
|
|
||
| def reverse_words(my_words) |
There was a problem hiding this comment.
I've the same comments as the ones I added to Ada-C10/reverse_words#24 (comment)
And accordingly, you may want to revisit the algorithm and the complexities for this assignment.
|
I've the same comments as the ones I added to Ada-C10/reverse_words#24 (comment) And accordingly, you may want to revisit the algorithm and the complexities for this assignment. The rest looks good. |
|
I've the same comments as the ones I added to Ada-C10/reverse_words#24 (comment) The rest looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time complexity: n^2
-nested loop within reverse words
Space Complexity: o(n)
-number of variables remain the same as array gets larger, but in reverse words, the new_string variable will get larger as my_words string increases.