Hayden - Edges - C10 " reverse words " coding challenge #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrutivanw
reviewed
Nov 14, 2018
| j -= 1 | ||
| end | ||
|
|
||
| i = max + 1 |
There was a problem hiding this comment.
Your algorithm does work currently for the test cases in place. At the end of the loop ending on line 29 however, i and j have the same values. Then, you update i to be max+1 on line 31. Which means in the most typical scenarios, j will be less than i after line 31. For efficiency, it might be worthwhile to make j also the same value.
|
Nice work! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time complexity of this algorithm is O(n), because it has to iterate through each character of the string. The space complexity is constant because the characters of the string are reversed in place.