Amber Lynn - Edges | reverse_words #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shrutivanw
reviewed
Nov 14, 2018
| ender = 0 | ||
|
|
||
| my_words.length.times do |i| | ||
| ender = i |
There was a problem hiding this comment.
To take care of multiple consecutive, white spaces, at the beginning of the times' loop you could check if my_words[start] is a white space. If it is, update, start to be i+1 and continue to the next iteration in the times' loop, otherwise, continue on with the rest of your logic.
|
Nice work! Take a look at my solution at https://github.com/Ada-C10/reverse_words/blob/solution/lib/reverse_words.rb Slack me if you have any questions on my comments or my solution or deducing the time and space complexity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
had trouble figuring out how to skip over spaces