Anibel & Hayden - Edges Rideshare On Rails

[anibelamerica]

Rideshare-Rails

Congratulations! You're submitting your assignment! These comprehension questions should be answered by both partners together, not by a single teammate.

Comprehension Questions

Question	Answer
Describe the types of entity relationships you set up in your project and why you set up the relationships that way	We created a one driver to many trips, one passenger to many trips, and many trips belong to one passenger/driver. We set up the relationships this way so that we could access specific trips for a single driver or passenger and display it appropriately.
Describe the role of model validations in your application	Model validations were done to ensure that any database changes were appropriate in the context of the table's columns and expected date types (i.e. edits didn't introduce strings as cost of a trip, name was present, etc).
How did your team break up the work to be done?	Our team had a lot scheduling rearrangements so we decided to divide the work mainly by functionality and views/styling. Difficult parts were discussed together.
What features did you choose to prioritize in your project, and what features, if any, did you have to set aside to meet the deadline?	We prioritized CRUD, overall functionality of the intended website, and a front end experience that would make our sickly selves happy. To make the deadline, we've sacrificed at least working to get in more extensive error validations and implementing responsive web design.
What was one thing that your team collectively gained more clarity on after completing this assignment?	We both gained a lot of practical insight into using Git. Branching, checkout, merging, etc… This was the first time that I (Hayden) had really used any of these Git features and I think both of us feel a lot more comfortable with them now.
What is your Trello board URL?	https://trello.com/b/PQUsaLXW
What is the Heroku URL of your deployed application?	https://rideshare-on-rails.herokuapp.com/
What are two discussion points that you and your pair discussed when giving/receiving feedback from each other that you would be willing to share?	Both of us pointed out how excited we had been to work with one another! But also acknowledged the difficulties of us both being sick for such a momentous occasion! We both affirmed how we felt that our decision to specialize and split project responsibilities worked out well in this situation.

[tildeee]

Rideshare Rails

What We're Looking For

Feature	Feedback
Baseline
Appropriate git usage with no extraneous files checked in and both partners contributing	x
Answered comprehension questions	x
Uses named routes (like _path)	x
RESTful routes utilized	x
Project Requirements
Table relationships	x
Validation rules for Models	x
Business logic is in the models	x
Database is seeded from the CSV files	x
Trello board is created and utilized in project management	x
Heroku instance is online	x
The app is styled to create an attractive user interface	x
Overall

Good work with this Anibel and Hayden! The code looks good overall and the project looks great too

I have a few comments for the code... My two "big" comments are:

What happens if there are no trips associated with a driver? Then total would be 0.0 and trip_count is 0. Ruby evaluates 0.0 / 0 as NaN or "Not A Number." When it gets to the driver/show.html.erb view, NaN.to_s evaluates to just "NaN" so it shows up on the driver page as "NaN" on the page. It'll show up like this:

"Minnie Dach
Average rating: NaN"

The search feature for finding a specific driver or passenger is wonderful! Great work on that.

Otherwise, in general, this project is great-- great work you two, despite being sick. Thanks for pushing through the challenges.

[tildeee]

Wonderful controller code! I love rendering a view and sending a status with it! That's the thoroughness and detail I like!

[tildeee]

Small comment, but this view doesn't format the cost to have a decimal two places in ;) trips costs are in the thousands haha

[tildeee]

Just out of curiosity, what does this class represent or do? I didn't find other uses of this class name

[haydenwalls]

it was originally used to put a decorative line between menu options but was later scrapped. class should have been removed :)

[tildeee]

Interesting, especially in conjunction with the implementation of the show action for PagesController... Though I'm not convinced that it needed to be like this-- why not just have a specific route for a "home" action defined in the PagesController, instead of using a URL param?

aka

get "/home" => "pages#home"

[haydenwalls]

It was set up so that many static pages could be created by any name. that obv wasn't used here though!