Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PORTS--Cloudy #40

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

PORTS--Cloudy #40

wants to merge 23 commits into from

Conversation

CloudyLopez
Copy link

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a custom model method you wrote. i did not. next time!
Describe how you approached testing that model method. What edge cases did you come up with? i did not get that far.
What are session and flash? What is the difference between them? session keeps it for the duration of everything vs flash that keeps it for that specific session.
What was one thing that you gained more clarity on through this assignment? flash and session.
What is the Heroku URL of your deployed application? uhhhh.... its baking.
Do you have any recommendations on how we could improve this project for the next cohort? hmmm... perhaps not make it due at the same time as the assessment mostly. i had to choose what to concentrate on and media ranker lost.

@tildeee
Copy link

tildeee commented May 2, 2019

Media Ranker

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Why was your first commit 2 days after the project started?
Comprehension questions Your definitions of how flash and session aren't correct; come see me at some point to go over this material
General
Rails fundamentals (RESTful routing, use of named paths) an okay job, with errors
Views are well-organized (DRY, use of semantic HTML, use of partials) There are things that could be improved, nice work with partial views
Errors are reported to the user
Business logic lives in the models
Models are thoroughly tested, including relations, validations and any custom logic
Controllers are thoroughly tested, including the login/logout process and multi-step workflows like voting for a work
Wave 1 - Media
Splash page shows the three media categories x
Basic CRUD operations on media are present and functional only show and create
Wave 2 - Users and Votes
Users can log in and log out
The ID of the current user is stored in the session
A user cannot vote for the same media more than once
All media lists are ordered by vote count
Splash page contains a media spotlight
Wave 3 - Users and Votes
Media pages contain lists of voting users
Individual user pages and the user list are present
Optional - Styling
Bootstrap is used appropriately
Look and feel is similar to the original
Overall

Cloudy, let's meet and talk about what happened with this project; your TaskList project was farther along than this. You and I have spoke about speed before, but I want to look back on this project and talk about:

  • Your git hygiene, habits, and workflow
  • Getting code on the screen
  • How to go for low-hanging fruit first

As always; the code you have is good. You got the beginnings of the WorksController correct. But I want to understand how this project got to the state that it's in, and what you need to change in order to push forward.


<p>Creator: <%= @work.creator%> </p>

<div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content inside of this div should be indented

config/routes.rb Outdated
@@ -0,0 +1,10 @@
Rails.application.routes.draw do
get 'works/index'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you define this path?

config/routes.rb Outdated
root to: "works#index"
# For details on the DSL available within this file, see http://guides.rubyonrails.org/routing.html
# root to: 'works#path'
resources :works
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

watch your indentation

@@ -0,0 +1,23 @@
<h1>Works#index</h1>
<p>Find me in app/views/works/index.html.erb</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect at least this h1 and this p to be deleted at some point...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants