Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports - Amy W #48

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Ports - Amy W #48

wants to merge 21 commits into from

Conversation

amythetester
Copy link

Media Ranker

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
Describe a custom model method you wrote. I did not write a custom model method for this project, but if I had finished this project I would have written one for up voting.
Describe how you approached testing that model method. What edge cases did you come up with? For the model method described above I would ensure the following cases, that a user can upvote if they have not voted for the work yet, that a user can't upvote again if they have already upvoted a work, and the one user's upvote does not prevent another user from upvoting.
What are session and flash? What is the difference between them? Flash is used for showing error messages and has to do with the duration of a request cycle. Session is a browser session. This means that a user can be tracked via the browser.
What was one thing that you gained more clarity on through this assignment? The general setup of rails and how the MVC works.
What is the Heroku URL of your deployed application? https://media-ranker-3000.herokuapp.com/
Do you have any recommendations on how we could improve this project for the next cohort? N/A

@amythetester amythetester changed the title Amy W - Ports Ports - Amy W May 13, 2019
@tildeee
Copy link

tildeee commented May 14, 2019

Media Ranker

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene x
Comprehension questions x
General
Rails fundamentals (RESTful routing, use of named paths) x
Views are well-organized (DRY, use of semantic HTML, use of partials)
Errors are reported to the user
Business logic lives in the models I LOOOOVE your use of scope!!!!
Models are thoroughly tested, including relations, validations and any custom logic
Controllers are thoroughly tested, including the login/logout process and multi-step workflows like voting for a work
Wave 1 - Media
Splash page shows the three media categories
Basic CRUD operations on media are present and functional x
Wave 2 - Users and Votes
Users can log in and log out
The ID of the current user is stored in the session
A user cannot vote for the same media more than once
All media lists are ordered by vote count
Splash page contains a media spotlight
Wave 3 - Users and Votes
Media pages contain lists of voting users
Individual user pages and the user list are present
Optional - Styling
Bootstrap is used appropriately x...? haha
Look and feel is similar to the original
Overall

Hi Amy!

Overall, you and I got to talk about this, so hopefully we're on the same page:
You didn't get through much on this project!

The things I want to make sure you get the learning goals of are the following:

  • Understanding custom routes with interesting functionality, via voting
  • Model business logic and model testing
  • logging in with session
  • giving feedback with flash

I have checked in with you about getting those learning goals, but let me know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants