Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sockets - Carla #29

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Sockets - Carla #29

wants to merge 4 commits into from

Conversation

carlabosco
Copy link

Litter Patrol

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
How are events / event handlers and this.state connected? 'this.state' keeps track of the object's state, which can be modified through event handlers.
What are two ways to do "dynamic styling" with React? When should they be used? Inline or by linking the js file to a CSS stylesheet. The stylesheet is always prefered.
Much like Rails works with the HTTP request->response cycle, React works with the browser's input->output cycle. Describe React's cycle from receiving user input to outputting different page content. When the user interacts with an element on the page, the corresponding event handler function will run and the state will be updated, so the render function runs again.
Compare how React and Rails' views differ. Given different circumstances, these systems have different goals. How does this impact on their design and how we are supposed to use them? React seems to be a lot more dynamic and the right choice for interactive pages. Rails seems more appropriate for projects that rely more heavily on business logic and database integration.
What was a challenge you were able to overcome on this assignment? Just getting it done! Making all icons render on the page and updating the score were the hardest parts.

CS Fundamentals Questions

Question Answer
Consider the code on the first few lines of App.render (it starts with this.state.items.map). What is the Big-O time complexity of this code, where n is the number of active game items? The map function would be linear, since it would have to traverse the entire array of items.
What part of React might benefit most from the use of specific data structure and algorithms?
Consider what happens when React processes a state change from setState -- it must re-render all of the components that now have different content because of that change.
What kind of data structure are the components in, and what sort of algorithms would be appropriate for React's code to "traverse" those components?
Speculate wildly about what the Big-O time complexity of that code might be.

@dHelmgren
Copy link

Litter Patrol

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good
Comprehension questions Good attempt, we will send out a solution gist
Functionality
Clicking on litter or nature shows a check or X respectively yes
Clicking on litter appropriately updates the score yes
Under the Hood
JavaScript is well-organized and easy to read yes
Functions are named appropriately could be better, see comment
Callback functions are passed to components appropriately yes
Overall Good work overall! If we wanted the score to only go up once the first time we clicked on litter, what would have to change?

height: PropTypes.number.isRequired,
layer: PropTypes.number.isRequired,
}

onItemClick = () => {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's confusing to have these named so similarly. Could you give it a different name that is easier to differentiate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants