Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ports - Cloudy #33

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Ports - Cloudy #33

wants to merge 4 commits into from

Conversation

CloudyLopez
Copy link

Litter Patrol

Congratulations! You're submitting your assignment!

Comprehension Questions

Question Answer
How are events / event handlers and this.state connected? event handlers handle events... they update the state theyre handling.
What are two ways to do "dynamic styling" with React? When should they be used? not sure as the styling was predetermined by Charles.
Much like Rails works with the HTTP request->response cycle, React works with the browser's input->output cycle. Describe React's cycle from receiving user input to outputting different page content. event handers wait for 'direction' and then the virtual dom talks to the dom-dom.
Compare how React and Rails' views differ. Given different circumstances, these systems have different goals. How does this impact on their design and how we are supposed to use them? react only deals with the V in the [rails] MVC so its different.
What was a challenge you were able to overcome on this assignment? patience! working on games was not fun. layers?! what?! Why!

CS Fundamentals Questions

Question Answer
Consider the code on the first few lines of App.render (it starts with this.state.items.map). What is the Big-O time complexity of this code, where n is the number of active game items? O of n (bc thats all i can do.)
What part of React might benefit most from the use of specific data structure and algorithms? components
Consider what happens when React processes a state change from setState -- it must re-render all of the components that now have different content because of that change.
What kind of data structure are the components in, and what sort of algorithms would be appropriate for React's code to "traverse" those components?
Speculate wildly about what the Big-O time complexity of that code might be.
uhhhh

@CheezItMan
Copy link

Litter Patrol

What We're Looking For

Feature Feedback
Core Requirements
Git hygiene Good number of commits and good commit messages
Comprehension questions Check, a little more detail on the react event cycle is best. The DOM triggers an event and react event listeners respond by updating state. The change in state triggers a re-render and this causes the dom to be updated.
Functionality
Clicking on litter or nature shows a check or X respectively Check
Clicking on litter appropriately updates the score Check
Under the Hood
JavaScript is well-organized and easy to read Check
Functions are named appropriately Check
Callback functions are passed to components appropriately Check
Overall Nice work, you hit all the learning goals on this project. Good work!

spot: false
};
}
static propTypes = {
height: PropTypes.number.isRequired,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably add an event handler for the callback function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants