Sockets - Cyndi #39
Open
Sockets - Cyndi #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Faiza1987
reviewed
Apr 5, 2019
| font-size: 13px; | ||
| padding: 40px 50px 40px 50px; | ||
| background-color: whitesmoke; | ||
|
|
There was a problem hiding this comment.
The alignment of the quotes is a little off. The speaker appears to be a quote of its own.
Faiza1987
reviewed
Apr 5, 2019
| @@ -0,0 +1,206 @@ | |||
| /* .container{ | |||
There was a problem hiding this comment.
General comment for entire code body: font size is a little small. Makes it a bit hard to read.
Faiza1987
reviewed
Apr 5, 2019
| padding-left: 75px; | ||
| padding-right: 75px; | ||
| } | ||
|
|
There was a problem hiding this comment.
Team members should be in a reverse triangle shape. This can be achieved by dividing them in 2 divs (3 in first div, and the last 2 in the 2nd div) though there is prob ably a much more concise way than mine out there.
|
Your project looks awesome! I especially liked the flex wrapping when the screen size changed. Also the color on hover for button was also great. Great work! |
|
Forgot to answer the Comprehension questions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Startrly
Congratulations! You're submitting your assignment.
Comprehension Questions