Adagrams submission from Mona and Tram #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Sep 21, 2020
Comment on lines
+1
to
+2
| # create draw_letters method | ||
| def draw_letters |
There was a problem hiding this comment.
👍 , very straightforward and effective.
| return hand_of_letters.sample(10) | ||
| end | ||
|
|
||
| def uses_available_letters?(input, letters_in_hand) |
Comment on lines
+31
to
+32
| def score_word(word) | ||
| letters_and_value = { |
There was a problem hiding this comment.
👍
I really like the use of a hash here!
| return {word: word, score: score_word(word)} if word.length == 10 | ||
| end | ||
|
|
||
| return words_and_scores_array.select {|hash| hash[:score] == max_score}.sort_by{|hash| hash[:word].length}[0] |
There was a problem hiding this comment.
Really clever way to get the smallest of the highest scoring words.
| return score | ||
| end | ||
|
|
||
| def highest_score_from(words) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assignment Submission: Adagrams
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
Enumerablemixin? If so, where and why was it helpful?