Fire - Roshni #18
Open
Fire - Roshni #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Mar 23, 2021
Comment on lines
+20
to
22
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def add_first(value) |
Comment on lines
+23
to
+29
| if @head | ||
| new_node = Node.new(value) | ||
| new_node.next = @head | ||
| @head = new_node | ||
| else | ||
| @head = Node.new(value) | ||
| end |
There was a problem hiding this comment.
Let me suggest this as simpler.
Suggested change
| if @head | |
| new_node = Node.new(value) | |
| new_node.next = @head | |
| @head = new_node | |
| else | |
| @head = Node.new(value) | |
| end | |
| @head = Node.new(value, @head) |
Comment on lines
+34
to
36
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def search(value) |
Comment on lines
+52
to
54
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_max |
Comment on lines
+71
to
73
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_min |
Comment on lines
+129
to
131
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def get_at_index(index) |
Comment on lines
+147
to
149
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def visit |
Comment on lines
+160
to
162
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def delete(value) |
Comment on lines
+182
to
184
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def reverse |
Comment on lines
+202
to
204
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def get_last |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.