Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sandy | fire #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .idea/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

32 changes: 32 additions & 0 deletions .idea/linked-list.iml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions .idea/misc.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions .idea/modules.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions .idea/vcs.xml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,7 @@ gem 'minitest-spec'
gem 'minitest-reporters'
gem "pry"
gem 'minitest-skip'
gem 'minitest', group: :test
gem 'minitest-reporters', group: :test


246 changes: 151 additions & 95 deletions lib/linked_list.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,148 +12,204 @@ def initialize(value, next_node = nil)

# Defines the singly linked list
class LinkedList
def initialize
@head = nil # keep the head private. Not accessible outside this class
end

def initialize
@head = nil # keep the head private. Not accessible outside this class
end
# method to add a new node with the specific data value in the linked list
# insert the new node at the beginning of the linked list
# Time Complexity: ?
# Space Complexity: ?
def add_first(value)
raise NotImplementedError
end

# Time Complexity: O(1)
# Space Complexity:? O(1)
def add_first(value)
Comment on lines +20 to +22

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

new_node = Node.new(value)
new_node.next = @head
@head = new_node
end
# method to find if the linked list contains a node with specified value
# returns true if found, false otherwise
# Time Complexity: ?
# Space Complexity: ?
def search(value)
raise NotImplementedError
# Time Complexity: O(n)
# Space Complexity: O(n)
def search(value)
Comment on lines +29 to +31

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , but the space complexity is O(1)

current_node = @head

while current_node
if current_node.data == value
return true
end
current_node = current_node.next
end

return false
end
# method to return the max value in the linked list
# returns the data value and not the node
def find_max
raise NotImplementedError
def find_max

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, except when the list is empty.

current_node = @head
max = current_node.data
current_node = current_node.next

while current_node != nil
if current_node.data > max
max = current_node.data
end
current_node = current_node.next
end

return max
end
# method to return the min value in the linked list
# returns the data value and not the node
# Time Complexity: ?
# Space Complexity: ?
def find_min
raise NotImplementedError
# Time Complexity: O(n)
# Space Complexity: O(1)
def find_min
Comment on lines +59 to +61

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works, except when the list is empty.

current_node = @head
min = current_node.data
current_node = current_node.next

while current_node != nil
if current_node.data < min
min = current_node.data
end
current_node = current_node.next
end


return min
end
# Additional Exercises
# returns the value in the first node
# returns nil if the list is empty
# Time Complexity: ?
# Space Complexity: ?
def get_first
raise NotImplementedError
end

# Time Complexity: O(1)
# Space Complexity: O(1)
def get_first
Comment on lines +77 to +79

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return nil if @head.nil?
return @head.data
end
# method that inserts a given value as a new last node in the linked list
# Time Complexity: ?
# Space Complexity: ?
def add_last(value)
raise NotImplementedError
end

# Time Complexity: O(n)
# Space Complexity: O(1)
def add_last(value)
Comment on lines +84 to +86

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return @head = Node.new(value) if @head.nil?
current_node= @head
while current_node.next != nil
current_node= current_node.next
end
current_node.next = Node.new(value)
end
# method that returns the length of the singly linked list
# Time Complexity: ?
# Space Complexity: ?
def length
raise NotImplementedError
# Time Complexity: O(n)
# Space Complexity: O(1)
def length
Comment on lines +95 to +97

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

current_node = @head
count = 0

while current_node != nil
count += 1
current_node = current_node.next
end

return count
end
# method that returns the value at a given index in the linked list
# index count starts at 0
# returns nil if there are fewer nodes in the linked list than the index value
# Time Complexity: ?
# Space Complexity: ?
def get_at_index(index)
raise NotImplementedError
end

# Time Complexity: O(n)
# Space Complexity: O(1)
def get_at_index(index)
Comment on lines +111 to +113

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

current_node = @head
i = 0

while current_node != nil
if i == index
return current_node.data
end
current_node = current_node.next
i += 1
end
return nil
end
# method to print all the values in the linked list
# Time Complexity: ?
# Space Complexity: ?
def visit
raise NotImplementedError
# Time Complexity: O(n)
# Space Complexity: O(1)
def visit
Comment on lines +127 to +129

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

return nil if @head.nil?
current_node = @head
while current_node != nil
print current_node.data
current_node = current_node.next
end

end
# method to delete the first node found with specified value
# Time Complexity: ?
# Space Complexity: ?
def delete(value)
raise NotImplementedError
end

# Time Complexity:
# Space Complexity:
def delete(value)
# ??
end
Comment on lines +140 to +142

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noting this isn't done

# method to reverse the singly linked list
# note: the nodes should be moved and not just the values in the nodes
# Time Complexity: ?
# Space Complexity: ?
def reverse
raise NotImplementedError
end

# Time Complexity: O(n)
# Space Complexity: O(1)
def reverse
Comment on lines +145 to +147

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

current_node = @head
previous_node = nil

while current_node != nil
next_node = current_node.next
current_node.next = previous_node
previous_node = current_node
current_node = next_node
end
@head = previous_node
end
# method that returns the value of the last node in the linked list
# returns nil if the linked list is empty
# Time Complexity: ?
# Space Complexity: ?
def get_last
raise NotImplementedError
# Time Complexity: O(n)
# Space Complexity: O(1)
def get_last
Comment on lines +161 to +163

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

if @head == nil
return
end

current_node = @head
while current_node.next != nil
current_node = current_node.next
end

current_node.next = @head
end
## Advanced Exercises
# returns the value at the middle element in the singly linked list
# Time Complexity: ?
# Space Complexity: ?
def find_middle_value
raise NotImplementedError
end

def find_middle_value
raise NotImplementedError
end
# find the nth node from the end and return its value
# assume indexing starts at 0 while counting to n
# Time Complexity: ?
# Space Complexity: ?
def find_nth_from_end(n)
raise NotImplementedError
end

def find_nth_from_end(n)
raise NotImplementedError
end
# checks if the linked list has a cycle. A cycle exists if any node in the
# linked list links to a node already visited.
# returns true if a cycle is found, false otherwise.
# Time Complexity: ?
# Space Complexity: ?
def has_cycle
raise NotImplementedError
end

def has_cycle
raise NotImplementedError
end
# method to insert a new node with specific data value, assuming the linked
# list is sorted in ascending order
# Time Complexity: ?
# Space Complexity: ?
def insert_ascending(value)
raise NotImplementedError
end

def insert_ascending(value)
raise NotImplementedError
end
# Helper method for tests
# Creates a cycle in the linked list for testing purposes
# Assumes the linked list has at least one node
def create_cycle
return if @head == nil # don't do anything if the linked list is empty

# navigate to last node
current = @head
while current.next != nil
current = current.next
end

current.next = @head # make the last node link to first node
end
def create_cycle
return if @head == nil # don't do anything if the linked list is empty
# navigate to last node
current = @head
while current.next != nil
current = current.next
end
current.next = @head # make the last node link to first node
end
end
2 changes: 2 additions & 0 deletions test/linked_list_test.rb
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@


require_relative 'test_helper'


Expand Down
5 changes: 2 additions & 3 deletions test/test_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@
require 'minitest/autorun'
require "minitest/reporters"
require "minitest/skip_dsl"
require_relative '../lib/linked_list'


Minitest::Reporters.use! Minitest::Reporters::SpecReporter.new

require_relative '../lib/linked_list'

Minitest::Reporters.use!