Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Earth/Taylor #37

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Earth/Taylor #37

wants to merge 3 commits into from

Conversation

TaylorMililani
Copy link

No description provided.

Copy link

@CheezItMan CheezItMan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work Taylor, you hit the learning goals here. Well done. I did make some notes on space/time complexity and I'd like you to take a look at that.

Comment on lines +21 to 23
# Time Complexity: O(1)
# Space Complexity: O(1)
def add_first(value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +30 to 32
# Time Complexity: O(n)
# Space Complexity: O(n)
def search(value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , however the space complexity is O(1)

Comment on lines +46 to 48
# Time Complexity: O(n)
# Space Complexity: O(n)
def find_max

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , however the space complexity is O(1)

Comment on lines +64 to 66
# Time Complexity: O(n)
# Space Complexity: O(n)
def find_min

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , however the space complexity is O(1)

Comment on lines +84 to 86
# Time Complexity: O(1)
# Space Complexity: O(1)
def get_first

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +193 to 195
# Time Complexity: O(n)
# Space Complexity: O(n)
def get_last

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , however the space complexity is O(1)

Comment on lines +207 to 209
# Time Complexity: O(n)
# Space Complexity: O(n)
def find_middle_value

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , however the space complexity is O(1)

Comment on lines +226 to 228
# Time Complexity: O(n)
# Space Complexity: O(n)
def find_nth_from_end(n)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , however the space complexity is O(1)

Comment on lines +247 to 249
# Time Complexity: O(n)
# Space Complexity: O(n)
def has_cycle

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , however the space complexity is O(1)

Comment on lines +264 to 266
# Time Complexity: O(n)
# Space Complexity: O(n)
def insert_ascending(value)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 , however the space complexity is O(1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants