-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
India & Olga #23
base: master
Are you sure you want to change the base?
India & Olga #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For TicTacToe we reviewed test results, the checkForWinner
function, and onClickCallback
function. Both functions look good and do what's required. BTW I unskipped the reset button tests and they worked as well.
Good work implementing a React project using state and callback functions!
@@ -9,12 +9,16 @@ const generateSquareComponents = (squares, onClickCallback) => { | |||
// squares is a 2D Array, but | |||
// you need to return a 1D array | |||
// of square components | |||
const flatArray = [].concat.apply([], squares);//we made a 1d array | |||
const squaresList = flatArray.map(square => { | |||
return <Square value={square.value} id={square.id} onClickCallback={onClickCallback}/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should include a key={someUniqueValue}
attribute in any React component returned from .map
. That's why you're getting the warning the tests show.
return <Square value={square.value} id={square.id} onClickCallback={onClickCallback}/> | |
return <Square value={square.value} id={square.id} onClickCallback={onClickCallback} key={square.id} /> |
React Tic Tac Toe
Congratulations! You're submitting your assignment. Please reflect on the assignment with these questions.
Reflection
useState
connected?CS Fundamentals Questions
setState
-- it must re-render all of the components that now have different content because of that change.What kind of data structure are the components in, and what sort of algorithms would be appropriate for React's code to "traverse" those components?
Speculate wildly about what the Big-O time complexity of that code might be.