-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Earth - Kal #44
base: master
Are you sure you want to change the base?
Earth - Kal #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work Kal, thanks for getting this in. The methods you wrote all work, but I had some feedback on time/space complexity.
# Time complexity: O(n) | ||
# Space complexity: O(n) | ||
def factorial(n) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
# Time complexity: O(n^2), where n is the length of the string | ||
# Space complexity: O(n^2), where n is the length of the string | ||
def reverse(s, pointer = s.length - 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
# Time complexity: O(n), where n is the length of the string. (More precisely, n/2) | ||
# Space complexity: O(n), where n is the length of the string. (More precisely, n/2) | ||
def reverse_inplace(s) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Nicely done!
# Time complexity: O(n) | ||
# Space complexity: O(n) | ||
def bunny(n) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
# Time complexity: O(n), where n is the length of the string | ||
# Space complexity: O(n), where n is the length of the string | ||
def nested(s, parens_counter = 0, pointer = 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
# Time complexity: O(n), where n is the length of the string | ||
# Space complexity: O(n), where n is the length of the string | ||
def search(array, value, pointer = 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
# Time complexity: O(n), where n is the length of the string (More precisely, n/2) | ||
# Space complexity: O(n), where n is the length of the string (More precisely, n/2) | ||
def is_palindrome(s, length = s.length, pointer = 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Well done!
No description provided.