Pipes - Angela- Hotel

Rakefile

@@ -0,0 +1,13 @@
+require 'rake/testtask'
+
+Rake::TestTask.new do |t|
+  t.libs = ["lib"]
+  t.warning = true
+  t.test_files = FileList['specs/*_spec.rb']
+  puts ""
+end
+
+task default: :test
+
+
+puts

design-activity.md

@@ -0,0 +1,44 @@
+What classes does each implementation include? Are the lists the same?
+  - Each implementation has the same class names:
+    1. CartEntry
+    2. ShoppingCart
+    3. Order
+  - The lists, what I interpret as list of classes, is the same.
+
+Write down a sentence to describe each class.
+  1. CartEntry - Responsible for creating entries for the cart
+  2. ShoppingCart - responsible for making carts that can hold entries and their prices
+  3. Order - calculates the shopping carts' entries total price
+
+How do the classes relate to each other? It might be helpful to draw a diagram on a whiteboard or piece of paper.
+  - Order relies on ShoppingCart and ShoppingCart relies on CartEntry
+
+What data does each class store? How (if at all) does this differ between the two implementations?
+  - From what I can tell, each implementation's classes store the same thing. ShoppingCart = entries and order = shopping cart instances.
+
+What methods does each class have? How (if at all) does this differ between the two implementations?
+
+
+Consider the Order#total_price method. In each implementation:
+Is logic to compute the price delegated to "lower level" classes like ShoppingCart and CartEntry, or is it retained in Order?
+  - Imp A delegated to both ShoppingCart and CartEntry by utilizing their instance variables
+  - Imp B did not, it was wrapped up nicely so that only messages were sent not responsibilities.
+
+Does total_price directly manipulate the instance variables of other classes?
+  - Imp A yes. it manipulates CartEntry#unit_price and CartEntry#quantity
+  - Imp B does not.
+
+If we decide items are cheaper if bought in bulk, how would this change the code? Which implementation is easier to modify?
+  - Imp B is easier to change than Imp A. We would add the logic to CartEntry#price
+
+Which implementation better adheres to the single responsibility principle?
+  - Imp B
+
+Bonus question once you've read Metz ch. 3: Which implementation is more loosely coupled?
+  - Imp B
+
+____________________________________
+
+My Hotel
+
+Hotel::Admin#add_reservation_to_block method was tightly coupled to Block class per Dan's comment. So I refactored the code so only messages were sent between the two classes and those loosely coupled them. For example, I added the instance reservation directly to Block#reservation_array and this was a poor idea.

lib/Admin.rb

@@ -0,0 +1,122 @@
+require_relative 'reservation'
+require_relative 'block'
+require 'pry'
+require 'date'
+
+module Hotel
+  class Admin
+
+    attr_reader :blocks, :room_nums, :reservations_array
+
+    def initialize
+      @blocks = []
+      @room_nums = []
+      20.times do |i|
+        @room_nums << (i + 1)
+      end
+
+      # @reservations_array1 = []
+
+    end # end initialize
+
+
+
+    def list_of_rooms
+      return Array.new(room_nums)
+    end
+
+
+    # I do not remember why I had this method. Kept it for future reference.
+    # def add_block(room_num_array, check_in, check_out, block_id, discount_percent: 0)
+    #   @blocks << Hotel::Block.new(room_num_array, check_in, check_out, block_id, discount_percent: 0)
+    # end
+
+    # Wave 2 requirement. Add reservation only no block
+    # Kept this code because wave 2 requires it. As for instructor feedback provided after first submition. Please see the create_block_by_date method on line 87'ish
+    def add_reservation(room_selection, check_in, check_out)
+      # self.add_block()
+      # self.add_reservation_to_block()
+      @reservations << Hotel::Reservation.new(room_selection, check_in, check_out)
+    end
+
+
+    def list_reservations(date)
+      rez_by_date = []
+      @blocks.each do |block|
+        if block.block_date_range.include(date)
+          block.reservations_array.each do |reservation|
+            rez_by_date << reservation
+          end
+        end
+      end
+      return rez_by_date
+    end
+
+    def list_vacancies(check_in, check_out)
+      available_rooms = list_of_rooms
+
+      date_range = DateRange.new(check_in, check_out)
+
+
+        @blocks.each do |block|
+          if block.block_date_range.overlap?(date_range)
+            block.room_num_array.each do |room_num|
+              available_rooms.delete(room_num)
+            end
+          end
+        end
+
+      return available_rooms
+    end
+
+    # creates block with available room for a given date range. Dan, I read you original feedback about the discount_percent passing through to calc price and ran out of time for testing. Now I worked on it for a while and I was not able to solve it. I will ask Charles for help.
+    def create_block_by_date(rooms_per_block, check_in, check_out, block_id, discount_percent: 0.0)
+      while self.list_vacancies(check_in, check_out).empty?
+        raise StandardError("No more vacancies!")
+      end
+
+      room_num_array = self.list_vacancies(check_in, check_out).take(rooms_per_block).to_a
+
+      # take one of the rooms from the room_num_array to make a reservation
+      room_num = room_num_array.first
+
+      new_block = Hotel::Block.new(room_num_array, check_in, check_out, block_id, discount_percent: 0.0)
+
+      new_block.make_reservation(room_num, check_in, check_out, discount_percent: 0)
+
+      @blocks << new_block
+    end
+
+    def find_block(id)
+      @blocks.each do |block|
+        if block.block_id == id
+          return block
+        end
+      end
+    end
+
+
+    # Dan I saw your original feedback about the below method not being necessary. My thought at the time was single responsibility for this method and then utiling it in the find_rooms_from_block method. If my thinking is incorrect, please let me know.
+    def list_available_blocked_rooms(id)
+      #find the block.
+      # access its assigned rooms
+      return self.find_block(id).room_num_array
+    end
+
+
+    def find_rooms_from_block(id, num_rooms_to_reserve)
+      return self.list_available_blocked_rooms(id).take(num_rooms_to_reserve)
+    end
+
+
+    def add_reservation_to_block(id, num_rooms_to_reserve, check_in, check_out, discount_percent: 0)
+      block = self.find_block(id)
+      num_rooms_to_reserve = self.find_rooms_from_block(id, num_rooms_to_reserve)
+
+      num_rooms_to_reserve.length.times do |room_num|
+        # block.reservations_array << Hotel::Reservation.new(room_num, check_in, check_out, discount_percent: 0)
+        block.make_reservation(room_num, check_in, check_out, discount_percent: 0)
+      end
+    end
+  end # end class
+end # end module

lib/Block.rb

@@ -0,0 +1,40 @@
+require 'date'
+
+require_relative 'daterange'
+
+module Hotel
+  class Block
+    COST_PER_NIGHT = 200.00
+
+    attr_reader  :room_num_array, :block_date_range, :discount_percent, :block_id, :reservations_array
+
+    def initialize(room_num_array, check_in, check_out, block_id, discount_percent: 0)
+
+
+      @room_num_array = room_num_array
+      @block_date_range = DateRange.new(check_in, check_out)
+      # what to automate block_id and was stumped on implementation. So I opted for manuel entry
+      @block_id = block_id
+      @discount_percent = discount_percent
+
+
+      @reservations_array = []
+    end
+
+
+
+    def total_cost
+      full_price = (@block_date_range.total_num_of_nights) * COST_PER_NIGHT
+      discount = full_price * (discount_percent/100.0)
+      return total_cost = full_price - discount
+    end
+
+
+    def make_reservation(room_num, check_in, check_out, discount_percent: 0)
+      reservations_array << Hotel::Reservation.new(room_num, check_in, check_out, discount_percent: 0)
+    end
+
+
+
+  end # end class
+end #end module

lib/DateRange.rb

@@ -0,0 +1,35 @@
+
+
+module Hotel
+
+  class DateRange
+
+    attr_reader :check_in, :check_out
+
+    def initialize(check_in, check_out)
+      raise ArgumentError.new("Please enter a Check Out date that comes after Check In date.") if check_in >= check_out
+
+      @check_in = check_in
+      @check_out = check_out
+    end
+
+
+    def include(date)
+      if date >= @check_in && date <= @check_out
+        return true
+      end
+    end
+
+    def overlap?(other)
+      return !(other.check_out <= @check_in || other.check_in >= @check_out)
+    end
+
+    def total_num_of_nights
+      return check_out - check_in
+    end
+
+
+
+
+  end
+end

lib/Reservation.rb

@@ -0,0 +1,34 @@
+require 'date'
+
+require_relative 'daterange'
+
+module Hotel
+  class Reservation
+    COST_PER_NIGHT = 200.00
+
+    attr_reader :total_cost, :room_num, :date_range
+
+    def initialize(room_num, check_in, check_out, discount_percent: 0)
+
+      # @reservation_array = []
+      @total_cost = 0
+      @room_num = room_num
+      @date_range = DateRange.new(check_in, check_out)
+    end
+
+    # def total_cost
+    #   full_price = (@block_date_range_array.length - 1) * COST_PER_NIGHT
+    #   discount = full_price * (discount_percent/100.0)
+    #   return total_cost = full_price - discount
+    # end
+
+    def total_cost
+      full_price = (@date_range.total_num_of_nights) * COST_PER_NIGHT
+      discount = full_price * (discount_percent/100.0)
+      return total_cost = full_price - discount
+    end
+
+
+
+  end # end class
+end #end module